Chromium Code Reviews| Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.h |
| diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.h b/chrome/browser/page_load_metrics/metrics_web_contents_observer.h |
| index a57a65e5963f410332c9f94f0528175069734f9d..3c0ea873da48efd0629af411c0a624b437015140 100644 |
| --- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.h |
| +++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.h |
| @@ -29,10 +29,6 @@ class NavigationHandle; |
| class RenderFrameHost; |
| } // namespace content |
| -namespace IPC { |
| -class Message; |
| -} // namespace IPC |
| - |
| namespace page_load_metrics { |
| class PageLoadMetricsEmbedderInterface; |
| @@ -53,15 +49,13 @@ class MetricsWebContentsObserver |
| // have been observed. |
| class TestingObserver { |
| public: |
| - enum class IPCType { LEGACY, MOJO }; |
| - |
| explicit TestingObserver(content::WebContents* web_contents); |
| virtual ~TestingObserver(); |
| void OnGoingAway(); |
| virtual void OnCommit(PageLoadTracker* tracker) {} |
| - virtual void DidReceiveTimingUpdate(IPCType type) {} |
| + virtual void DidReceiveTimingUpdate() {} |
|
Bryan McQuade
2017/06/23 15:15:07
this callback was actually only really for verifyi
lpy
2017/06/23 21:23:46
Done.
|
| private: |
| page_load_metrics::MetricsWebContentsObserver* observer_; |
| @@ -81,8 +75,6 @@ class MetricsWebContentsObserver |
| ~MetricsWebContentsObserver() override; |
| // content::WebContentsObserver implementation: |
| - bool OnMessageReceived(const IPC::Message& message, |
| - content::RenderFrameHost* render_frame_host) override; |
| void DidFinishNavigation( |
| content::NavigationHandle* navigation_handle) override; |
| void DidRedirectNavigation( |
| @@ -152,11 +144,6 @@ class MetricsWebContentsObserver |
| void UpdateTiming(mojom::PageLoadTimingPtr timing, |
| mojom::PageLoadMetadataPtr metadata) override; |
| - // Called from legacy IPC. |
| - void OnUpdateTimingOverIPC(content::RenderFrameHost* render_frame_host, |
| - const mojom::PageLoadTiming& timing, |
| - const mojom::PageLoadMetadata& metadata); |
| - |
| void HandleFailedNavigationForTrackedLoad( |
| content::NavigationHandle* navigation_handle, |
| std::unique_ptr<PageLoadTracker> tracker); |