[PageLoadMetrics] Remove legacy IPC from Page Load Metrics.

chrome/browser/page_load_metrics/metrics_web_contents_observer.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_METRICS_WEB_CONTENTS_OBSERVER_H_
 #define CHROME_BROWSER_PAGE_LOAD_METRICS_METRICS_WEB_CONTENTS_OBSERVER_H_
 
 #include <map>
 #include <memory>
 #include <vector>
@@ skipping 11 matching lines @@
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/browser/web_contents_user_data.h"
 #include "content/public/common/resource_type.h"
 #include "third_party/WebKit/public/platform/WebInputEvent.h"
 
 namespace content {
 class NavigationHandle;
 class RenderFrameHost;
 }  // namespace content
 
-namespace IPC {
-class Message;
-}  // namespace IPC
-
 namespace page_load_metrics {
 
 class PageLoadMetricsEmbedderInterface;
 class PageLoadTracker;
 
 // MetricsWebContentsObserver tracks page loads and loading metrics
 // related data based on IPC messages received from a
 // MetricsRenderFrameObserver.
 class MetricsWebContentsObserver
     : public content::WebContentsObserver,
       public content::WebContentsUserData<MetricsWebContentsObserver>,
       public content::RenderWidgetHost::InputEventObserver,
       public mojom::PageLoadMetrics {
  public:
   // TestingObserver allows tests to observe MetricsWebContentsObserver state
   // changes. Tests may use TestingObserver to wait until certain state changes,
   // such as the arrivial of PageLoadTiming messages from the render process,
   // have been observed.
   class TestingObserver {
    public:
-    enum class IPCType { LEGACY, MOJO };
-
     explicit TestingObserver(content::WebContents* web_contents);
     virtual ~TestingObserver();
 
     void OnGoingAway();
 
     virtual void OnCommit(PageLoadTracker* tracker) {}
-    virtual void DidReceiveTimingUpdate(IPCType type) {}
+    virtual void DidReceiveTimingUpdate() {}

[Bryan McQuade, 2017/06/23 15:15:07]

this callback was actually only really for verifying we received updates for the
expected IPC type, so i think it's better to just remove this method altogether.

[lpy, 2017/06/23 21:23:46]

Done.

 
    private:
     page_load_metrics::MetricsWebContentsObserver* observer_;
 
     DISALLOW_COPY_AND_ASSIGN(TestingObserver);
   };
 
   // Note that the returned metrics is owned by the web contents.
   static MetricsWebContentsObserver* CreateForWebContents(
       content::WebContents* web_contents,
       const base::Optional<content::WebContents::CreateParams>& create_params,
       std::unique_ptr<PageLoadMetricsEmbedderInterface> embedder_interface);
   MetricsWebContentsObserver(
       content::WebContents* web_contents,
       const base::Optional<content::WebContents::CreateParams>& create_params,
       std::unique_ptr<PageLoadMetricsEmbedderInterface> embedder_interface);
   ~MetricsWebContentsObserver() override;
 
   // content::WebContentsObserver implementation:
-  bool OnMessageReceived(const IPC::Message& message,
-                         content::RenderFrameHost* render_frame_host) override;
   void DidFinishNavigation(
       content::NavigationHandle* navigation_handle) override;
   void DidRedirectNavigation(
       content::NavigationHandle* navigation_handle) override;
   void NavigationStopped() override;
   void OnInputEvent(const blink::WebInputEvent& event) override;
   void WasShown() override;
   void WasHidden() override;
   void RenderProcessGone(base::TerminationStatus status) override;
   void RenderViewHostChanged(content::RenderViewHost* old_host,
@@ skipping 49 matching lines @@
                        const mojom::PageLoadTiming& timing,
                        const mojom::PageLoadMetadata& metadata);
 
  private:
   friend class content::WebContentsUserData<MetricsWebContentsObserver>;
 
   // page_load_metrics::mojom::PageLoadMetrics implementation.
   void UpdateTiming(mojom::PageLoadTimingPtr timing,
                     mojom::PageLoadMetadataPtr metadata) override;
 
-  // Called from legacy IPC.
-  void OnUpdateTimingOverIPC(content::RenderFrameHost* render_frame_host,
-                             const mojom::PageLoadTiming& timing,
-                             const mojom::PageLoadMetadata& metadata);
-
   void HandleFailedNavigationForTrackedLoad(
       content::NavigationHandle* navigation_handle,
       std::unique_ptr<PageLoadTracker> tracker);
 
   void HandleCommittedNavigationForTrackedLoad(
       content::NavigationHandle* navigation_handle,
       std::unique_ptr<PageLoadTracker> tracker);
 
   // Return a PageLoadTracker (either provisional or committed) that matches the
   // given request attributes, or nullptr if there are no matching
@@ skipping 56 matching lines @@
   base::ObserverList<TestingObserver> testing_observers_;
   content::WebContentsFrameBindingSet<mojom::PageLoadMetrics>
       page_load_metrics_binding_;
 
   DISALLOW_COPY_AND_ASSIGN(MetricsWebContentsObserver);
 };
 
 }  // namespace page_load_metrics
 
 #endif  // CHROME_BROWSER_PAGE_LOAD_METRICS_METRICS_WEB_CONTENTS_OBSERVER_H_