[Android] Suggest page title for homescreen shortcut when Web Manifest is empty

[Android] Suggest page title for homescreen shortcut when Web Manifest is empty

Previously, when a user tapped "add to home screen" in the app menu for a page
with a Web Manifest with empty "short_name" and "name" fields, the
add-to-homescreen-dialog would show with an empty text field.

This CL changes the behavior in this scenario so that the text field is
populated with the page title.

BUG=728300
TEST=ShortcutInfoTest.*

Review-Url: https://codereview.chromium.org/2948313002
Cr-Commit-Position: refs/heads/master@{#482440}
Committed: https://chromium.googlesource.com/chromium/src/+/d654734a905602faa2dd33b7a60f06fd80efcdfb

[pkotwicz, 2017-06-22 22:11:53]

pkotwicz@chromium.org changed reviewers:
+ dominickn@chromium.org

[pkotwicz, 2017-06-22 22:11:53]

Dominick, can you please take a look? This is the followup CL for
https://codereview.chromium.org/2950113003/

[dominickn, 2017-06-23 01:16:02]

lgtm, thanks!

[pkotwicz, 2017-06-26 21:31:54]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2017-06-26 21:32:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pkotwicz, 2017-06-26 21:33:44]

The CQ bit was unchecked by pkotwicz@chromium.org

[pkotwicz, 2017-06-26 21:46:16]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2017-06-26 21:46:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominickn@chromium.org
Link to the patchset: https://codereview.chromium.org/2948313002/#ps20001
(title: "Merge branch 'master' into ignore")

[commit-bot: I haz the power, 2017-06-26 21:46:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 22:35:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498513576884620,
"parent_rev": "692e54ad8c94b21dbc6c7e262de15f140bf68bc5", "commit_rev":
"d654734a905602faa2dd33b7a60f06fd80efcdfb"}

[commit-bot: I haz the power, 2017-06-26 22:35:43]

Description was changed from

==========
[Android] Suggest page title for homescreen shortcut when Web Manifest is empty

Previously, when a user tapped "add to home screen" in the app menu for a page
with a Web Manifest with empty "short_name" and "name" fields, the
add-to-homescreen-dialog would show with an empty text field.

This CL changes the behavior in this scenario so that the text field is
populated with the page title.

BUG=728300
TEST=ShortcutInfoTest.*
==========

to

==========
[Android] Suggest page title for homescreen shortcut when Web Manifest is empty

Previously, when a user tapped "add to home screen" in the app menu for a page
with a Web Manifest with empty "short_name" and "name" fields, the
add-to-homescreen-dialog would show with an empty text field.

This CL changes the behavior in this scenario so that the text field is
populated with the page title.

BUG=728300
TEST=ShortcutInfoTest.*

Review-Url: https://codereview.chromium.org/2948313002
Cr-Commit-Position: refs/heads/master@{#482440}
Committed:
https://chromium.googlesource.com/chromium/src/+/d654734a905602faa2dd33b7a60f...
==========

[commit-bot: I haz the power, 2017-06-26 22:35:45]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d654734a905602faa2dd33b7a60f...