Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2948273002: Correctly set root_library based on the application script URI instead of looking for the library t… (Closed)

Created:
3 years, 6 months ago by siva
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

1. Correctly set root_library based on the application script URI instead of looking for the library that has the 'main' method. 2. Adjust the Dart front end to not require a 'main' method when the in memory filesystem is used, this allows execution of VM unit tests which all do not necessarily have a 'main' method (integrated CL from siggi) 3. Change kernel reader to not look for a 'main' methos when Dart_LoadKernel is called. 4. Change Dart_LoadScript to also support loading of dart programs when Dart front end is used R=aam@google.com, sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/33c50e93741bae4a2d675a3690c9a4906befc2a5

Patch Set 1 #

Patch Set 2 : Fix. #

Patch Set 3 : Fix. #

Patch Set 4 : code formatting changes. #

Patch Set 5 : Integrate cl from Siggi for front end change to not require a 'main' method when using the memory f… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -238 lines) Patch
M runtime/bin/dfe.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M runtime/bin/gen_snapshot.cc View 1 2 3 4 1 chunk +6 lines, -2 lines 0 comments Download
M runtime/bin/loader.cc View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/bin/main.cc View 1 2 3 4 2 chunks +13 lines, -7 lines 0 comments Download
M runtime/tests/vm/vm.status View 1 2 3 4 9 chunks +32 lines, -124 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 3 4 8 chunks +53 lines, -27 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 2 3 4 18 chunks +56 lines, -57 lines 0 comments Download
M runtime/vm/unit_test.h View 1 2 3 4 3 chunks +5 lines, -1 line 0 comments Download
M runtime/vm/unit_test.cc View 1 2 3 4 6 chunks +22 lines, -11 lines 0 comments Download
M tests/co19/co19-kernel.status View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_kernel.status View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M utils/kernel-service/kernel-service.dart View 1 2 3 4 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
siva
3 years, 5 months ago (2017-07-18 01:06:49 UTC) #4
aam
lgtm!
3 years, 5 months ago (2017-07-18 14:42:58 UTC) #5
Siggi Cherem (dart-lang)
kernel-service change lgtm :)
3 years, 5 months ago (2017-07-18 16:31:59 UTC) #6
siva
3 years, 5 months ago (2017-07-20 01:09:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
33c50e93741bae4a2d675a3690c9a4906befc2a5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698