Correctly set root_library based on the application script URI instead of looking for the library t…

runtime/vm/dart_api_impl_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/dart_api_impl.h"
 #include "bin/builtin.h"
 #include "include/dart_api.h"
 #include "include/dart_mirrors_api.h"
 #include "include/dart_native_api.h"
 #include "include/dart_tools_api.h"
 #include "platform/assert.h"
 #include "platform/text_buffer.h"
 #include "platform/utils.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart_api_state.h"
 #include "vm/lockers.h"
 #include "vm/timeline.h"
 #include "vm/unit_test.h"
 #include "vm/verifier.h"
 
 namespace dart {
 
 DECLARE_FLAG(bool, verify_acquired_data);
 DECLARE_FLAG(bool, ignore_patch_signature_mismatch);
 DECLARE_FLAG(bool, support_externalizable_strings);
+DECLARE_FLAG(bool, use_dart_frontend);
 
 #ifndef PRODUCT
 
 TEST_CASE(ErrorHandleBasics) {
   const char* kScriptChars =
       "void testMain() {\n"
       "  throw new Exception(\"bad news\");\n"
       "}\n";
 
   Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
@@ skipping 55 matching lines @@
 
   Dart_ActivationFrame frame;
   result = Dart_GetActivationFrame(stacktrace, 0, &frame);
   EXPECT_VALID(result);
   result = Dart_ActivationFrameInfo(frame, &function_name, &script_url,
                                     &line_number, &column_number);
   EXPECT_VALID(result);
   Dart_StringToCString(function_name, &cstr);
   EXPECT_STREQ("bar", cstr);
   Dart_StringToCString(script_url, &cstr);
-  EXPECT_STREQ("test-lib", cstr);
+  EXPECT_SUBSTRING("test-lib", cstr);
   EXPECT_EQ(1, line_number);
   EXPECT_EQ(10, column_number);
 
   result = Dart_GetActivationFrame(stacktrace, 1, &frame);
   EXPECT_VALID(result);
   result = Dart_ActivationFrameInfo(frame, &function_name, &script_url,
                                     &line_number, &column_number);
   EXPECT_VALID(result);
   Dart_StringToCString(function_name, &cstr);
   EXPECT_STREQ("foo", cstr);
   Dart_StringToCString(script_url, &cstr);
-  EXPECT_STREQ("test-lib", cstr);
+  EXPECT_SUBSTRING("test-lib", cstr);
   EXPECT_EQ(2, line_number);
   EXPECT_EQ(10, column_number);
 
   result = Dart_GetActivationFrame(stacktrace, 2, &frame);
   EXPECT_VALID(result);
   result = Dart_ActivationFrameInfo(frame, &function_name, &script_url,
                                     &line_number, &column_number);
   EXPECT_VALID(result);
   Dart_StringToCString(function_name, &cstr);
   EXPECT_STREQ("testMain", cstr);
   Dart_StringToCString(script_url, &cstr);
-  EXPECT_STREQ("test-lib", cstr);
+  EXPECT_SUBSTRING("test-lib", cstr);
   EXPECT_EQ(3, line_number);
   EXPECT_EQ(15, column_number);
 
   // Out-of-bounds frames.
   result = Dart_GetActivationFrame(stacktrace, frame_count, &frame);
   EXPECT(Dart_IsError(result));
   result = Dart_GetActivationFrame(stacktrace, -1, &frame);
   EXPECT(Dart_IsError(result));
 }
 
@@ skipping 28 matching lines @@
   // Top frame at positioned at throw.
   Dart_ActivationFrame frame;
   result = Dart_GetActivationFrame(stacktrace, 0, &frame);
   EXPECT_VALID(result);
   result = Dart_ActivationFrameInfo(frame, &function_name, &script_url,
                                     &line_number, &column_number);
   EXPECT_VALID(result);
   Dart_StringToCString(function_name, &cstr);
   EXPECT_STREQ("foo", cstr);
   Dart_StringToCString(script_url, &cstr);
-  EXPECT_STREQ("test-lib", cstr);
+  EXPECT_SUBSTRING("test-lib", cstr);
   EXPECT_EQ(1, line_number);
   EXPECT_EQ(20, column_number);
 
   // Middle frames positioned at the recursive call.
   for (intptr_t frame_index = 1; frame_index < (frame_count - 1);
        frame_index++) {
     result = Dart_GetActivationFrame(stacktrace, frame_index, &frame);
     EXPECT_VALID(result);
     result = Dart_ActivationFrameInfo(frame, &function_name, &script_url,
                                       &line_number, &column_number);
     EXPECT_VALID(result);
     Dart_StringToCString(function_name, &cstr);
     EXPECT_STREQ("foo", cstr);
     Dart_StringToCString(script_url, &cstr);
-    EXPECT_STREQ("test-lib", cstr);
+    EXPECT_SUBSTRING("test-lib", cstr);
     EXPECT_EQ(1, line_number);
     EXPECT_EQ(40, column_number);
   }
 
   // Bottom frame positioned at testMain().
   result = Dart_GetActivationFrame(stacktrace, frame_count - 1, &frame);
   EXPECT_VALID(result);
   result = Dart_ActivationFrameInfo(frame, &function_name, &script_url,
                                     &line_number, &column_number);
   EXPECT_VALID(result);
   Dart_StringToCString(function_name, &cstr);
   EXPECT_STREQ("testMain", cstr);
   Dart_StringToCString(script_url, &cstr);
-  EXPECT_STREQ("test-lib", cstr);
+  EXPECT_SUBSTRING("test-lib", cstr);
   EXPECT_EQ(2, line_number);
   EXPECT_EQ(15, column_number);
 
   // Out-of-bounds frames.
   result = Dart_GetActivationFrame(stacktrace, frame_count, &frame);
   EXPECT(Dart_IsError(result));
   result = Dart_GetActivationFrame(stacktrace, -1, &frame);
   EXPECT(Dart_IsError(result));
 }
 
@@ skipping 3158 matching lines @@
   Dart_Isolate isolate =
       Dart_CreateIsolate(NULL, NULL, bin::core_isolate_snapshot_data,
                          bin::core_isolate_snapshot_instructions, NULL,
                          reinterpret_cast<void*>(mydata), &err);
   EXPECT(isolate != NULL);
   EXPECT_EQ(mydata, reinterpret_cast<intptr_t>(Dart_CurrentIsolateData()));
   EXPECT_EQ(mydata, reinterpret_cast<intptr_t>(Dart_IsolateData(isolate)));
   Dart_ShutdownIsolate();
 }
 
+static Dart_Handle LoadScript(const char* url_str, const char* source) {
+  Dart_Handle url = NewString(url_str);
+  Dart_Handle result;
+  Dart_Handle script;
+  if (!FLAG_use_dart_frontend) {
+    result = Dart_SetLibraryTagHandler(TestCase::library_handler);
+    EXPECT_VALID(result);
+    script = NewString(source);
+  } else {
+    void* kernel_pgm = NULL;
+    char* error =
+        TestCase::CompileTestScriptWithDFE(url_str, source, &kernel_pgm);
+    if (error != NULL) {
+      return Dart_NewApiError(error);
+    }
+    script = reinterpret_cast<Dart_Handle>(kernel_pgm);
+  }
+  return Dart_LoadScript(url, Dart_Null(), script, 0, 0);
+}
+
 VM_UNIT_TEST_CASE(IsolateSetCheckedMode) {
   const char* kScriptChars =
       "int bad1() {\n"
       "  int foo = 'string';\n"
       "  return foo;\n"
       "}\n"
       "\n"
       "int good1() {\n"
       "  int five = 5;\n"
       "  return five;"
@@ skipping 11 matching lines @@
   Dart_Isolate isolate = Dart_CreateIsolate(
       NULL, NULL, bin::core_isolate_snapshot_data,
       bin::core_isolate_snapshot_instructions, &api_flags, NULL, &err);
   if (isolate == NULL) {
     OS::Print("Creation of isolate failed '%s'\n", err);
     free(err);
   }
   EXPECT(isolate != NULL);
 
   {
+    Dart_Handle result;
     Dart_EnterScope();
-    Dart_Handle url = NewString(TestCase::url());
-    Dart_Handle source = NewString(kScriptChars);
-    Dart_Handle result = Dart_SetLibraryTagHandler(TestCase::library_handler);
-    EXPECT_VALID(result);
-    Dart_Handle lib = Dart_LoadScript(url, Dart_Null(), source, 0, 0);
+    Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
     EXPECT_VALID(lib);
     result = Dart_FinalizeLoading(false);
     EXPECT_VALID(result);
     result = Dart_Invoke(lib, NewString("bad1"), 0, NULL);
     EXPECT_ERROR(result,
                  "Unhandled exception:\n"
                  "type 'String' is not a subtype of type 'int' of 'foo'");
 
     result = Dart_Invoke(lib, NewString("good1"), 0, NULL);
     EXPECT_VALID(result);
@@ skipping 2218 matching lines @@
   result = Dart_LoadScript(url, Dart_True(), source, 0, 0);
   EXPECT(Dart_IsError(result));
   EXPECT_STREQ(
       "Dart_LoadScript expects argument 'resolved_url' to be of type String.",
       Dart_GetError(result));
 
   result = Dart_LoadScript(url, error, source, 0, 0);
   EXPECT(Dart_IsError(result));
   EXPECT_STREQ("incoming error", Dart_GetError(result));
 
-  result = Dart_LoadScript(url, Dart_Null(), Dart_Null(), 0, 0);
-  EXPECT(Dart_IsError(result));
-  EXPECT_STREQ("Dart_LoadScript expects argument 'source' to be non-null.",
-               Dart_GetError(result));
+  if (!FLAG_use_dart_frontend) {
+    result = Dart_LoadScript(url, Dart_Null(), Dart_Null(), 0, 0);
+    EXPECT(Dart_IsError(result));
+    EXPECT_STREQ("Dart_LoadScript expects argument 'source' to be non-null.",
+                 Dart_GetError(result));
 
-  result = Dart_LoadScript(url, Dart_Null(), Dart_True(), 0, 0);
-  EXPECT(Dart_IsError(result));
-  EXPECT_STREQ(
-      "Dart_LoadScript expects argument 'source' to be of type String.",
-      Dart_GetError(result));
+    result = Dart_LoadScript(url, Dart_Null(), Dart_True(), 0, 0);
+    EXPECT(Dart_IsError(result));
+    EXPECT_STREQ(
+        "Dart_LoadScript expects argument 'source' to be of type String.",
+        Dart_GetError(result));
 
-  result = Dart_LoadScript(url, Dart_Null(), error, 0, 0);
-  EXPECT(Dart_IsError(result));
-  EXPECT_STREQ("incoming error", Dart_GetError(result));
+    result = Dart_LoadScript(url, Dart_Null(), error, 0, 0);
+    EXPECT(Dart_IsError(result));
+    EXPECT_STREQ("incoming error", Dart_GetError(result));
+  }
 
   // Load a script successfully.
-  result = Dart_LoadScript(url, Dart_Null(), source, 0, 0);
+  result = TestCase::LoadTestScript(kScriptChars, NULL);
   EXPECT_VALID(result);
   Dart_FinalizeLoading(false);
 
   result = Dart_Invoke(result, NewString("main"), 0, NULL);
   EXPECT_VALID(result);
   EXPECT(Dart_IsInteger(result));
   int64_t value = 0;
   EXPECT_VALID(Dart_IntegerToInt64(result, &value));
   EXPECT_EQ(12345, value);
 
   // Further calls to LoadScript are errors.
   result = Dart_LoadScript(url, Dart_Null(), source, 0, 0);
   EXPECT(Dart_IsError(result));
-  EXPECT_STREQ(
-      "Dart_LoadScript: "
-      "A script has already been loaded from 'test-lib'.",
-      Dart_GetError(result));
+  EXPECT_SUBSTRING("Dart_LoadScript: A script has already been loaded from",
+                   Dart_GetError(result));
 }
 
 TEST_CASE(RootLibrary) {
   const char* kScriptChars =
       "library testlib;"
       "main() {"
       "  return 12345;"
       "}";
 
   Dart_Handle root_lib = Dart_RootLibrary();
   EXPECT_VALID(root_lib);
   EXPECT(Dart_IsNull(root_lib));
 
   // Load a script.
-  Dart_Handle url = NewString(TestCase::url());
-  Dart_Handle source = NewString(kScriptChars);
-  EXPECT_VALID(Dart_LoadScript(url, Dart_Null(), source, 0, 0));
+  EXPECT_VALID(LoadScript(TestCase::url(), kScriptChars));
 
   root_lib = Dart_RootLibrary();
   Dart_Handle lib_name = Dart_LibraryName(root_lib);
   EXPECT_VALID(lib_name);
   EXPECT(!Dart_IsNull(root_lib));
   const char* name_cstr = "";
   EXPECT_VALID(Dart_StringToCString(lib_name, &name_cstr));
   EXPECT_STREQ("testlib", name_cstr);
 
   Dart_Handle lib_uri = Dart_LibraryUrl(root_lib);
@@ skipping 58 matching lines @@
     default:
       EXPECT(false);
       return Api::NewError("invalid callback");
   }
   index += 1;
   return Api::Success();
 }
 
 TEST_CASE(LoadScript_CompileError) {
   const char* kScriptChars = ")";
-  Dart_Handle url = NewString(TestCase::url());
-  Dart_Handle source = NewString(kScriptChars);
   Dart_Handle result = Dart_SetLibraryTagHandler(import_library_handler);
   EXPECT_VALID(result);
-  result = Dart_LoadScript(url, Dart_Null(), source, 0, 0);
+  result = LoadScript(TestCase::url(), kScriptChars);
   EXPECT(Dart_IsError(result));
-  EXPECT(strstr(Dart_GetError(result), "unexpected token ')'"));
+  if (!FLAG_use_dart_frontend) {
+    EXPECT(strstr(Dart_GetError(result), "unexpected token ')'"));
+  }
 }
 
 TEST_CASE(LookupLibrary) {
   const char* kScriptChars =
       "import 'library1_dart';"
       "main() {}";
   const char* kLibrary1Chars =
       "library library1_dart;"
       "import 'library2_dart';";
 
@@ skipping 915 matching lines @@
   const char* kScriptChars =
       "class Test {"
       "  static foo() native \"SomeNativeFunction\";\n"
       "  static bar() native \"SomeNativeFunction2\";\n"
       "  static baz() native \"SomeNativeFunction3\";\n"
       "}";
   Dart_Handle error = Dart_NewApiError("incoming error");
   Dart_Handle result;
 
   // Load a test script.
-  Dart_Handle url = NewString(TestCase::url());
-  Dart_Handle source = NewString(kScriptChars);
-  result = Dart_SetLibraryTagHandler(library_handler);
-  EXPECT_VALID(result);
-  Dart_Handle lib = Dart_LoadScript(url, Dart_Null(), source, 0, 0);
+  Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
   EXPECT_VALID(lib);
   result = Dart_FinalizeLoading(false);
   EXPECT_VALID(result);
   EXPECT(Dart_IsLibrary(lib));
   Dart_Handle type = Dart_GetType(lib, NewString("Test"), 0, NULL);
   EXPECT_VALID(type);
 
   result = Dart_SetNativeResolver(Dart_Null(), &MyNativeResolver1, NULL);
   EXPECT(Dart_IsError(result));
   EXPECT_STREQ(
@@ skipping 473 matching lines @@
 }
 
 static Dart_Isolate RunLoopTestCallback(const char* script_name,
                                         const char* main,
                                         const char* package_root,
                                         const char* package_config,
                                         Dart_IsolateFlags* flags,
                                         void* data,
                                         char** error) {
   const char* kScriptChars =
-      "import 'builtin';\n"
       "import 'dart:isolate';\n"
       "void main(shouldThrowException) {\n"
       "  var rp = new RawReceivePort();\n"
       "  rp.handler = (msg) {\n"
       "    rp.close();\n"
       "    if (shouldThrowException) {\n"
       "      throw new Exception('ExceptionFromTimer');\n"
       "    }\n"
       "  };\n"
       "  rp.sendPort.send(1);\n"
       "}\n";
 
   if (Dart_CurrentIsolate() != NULL) {
     Dart_ExitIsolate();
   }
   Dart_Isolate isolate = TestCase::CreateTestIsolate(script_name);
   ASSERT(isolate != NULL);
   if (Dart_IsServiceIsolate(isolate)) {
     return isolate;
   }
   Dart_EnterScope();
-  Dart_Handle url = NewString(TestCase::url());
-  Dart_Handle source = NewString(kScriptChars);
-  Dart_Handle result = Dart_SetLibraryTagHandler(TestCase::library_handler);
-  EXPECT_VALID(result);
-  Dart_Handle lib = Dart_LoadScript(url, Dart_Null(), source, 0, 0);
+  Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
   EXPECT_VALID(lib);
-  result = Dart_FinalizeLoading(false);
+  Dart_Handle result = Dart_FinalizeLoading(false);
   EXPECT_VALID(result);
   Dart_ExitScope();
   Dart_ExitIsolate();
   bool retval = Dart_IsolateMakeRunnable(isolate);
   EXPECT(retval);
   return isolate;
 }
 
 // Common code for RunLoop_Success/RunLoop_Failure.
 static void RunLoopTest(bool throw_exception) {
@@ skipping 353 matching lines @@
       "  Expect.equals(3, obj.bar42(1, 1));\n"
       "  Expect.equals(6, obj.foo4(2, 2, 2));\n"
       "  Expect.equals(6, obj.bar43(2, 2, 2));\n"
       "\n"
       "  return 0;\n"
       "}\n";
 
   Dart_Handle result;
 
   // Load a test script.
-  Dart_Handle url = NewString(TestCase::url());
-  Dart_Handle source = NewString(kScriptChars);
-  result = Dart_SetLibraryTagHandler(library_handler);
-  EXPECT_VALID(result);
-  Dart_Handle lib = Dart_LoadScript(url, Dart_Null(), source, 0, 0);
+  Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
   EXPECT_VALID(lib);
   EXPECT(Dart_IsLibrary(lib));
   result = Dart_SetNativeResolver(lib, &MyNativeClosureResolver, NULL);
   EXPECT_VALID(result);
   result = Dart_FinalizeLoading(false);
   EXPECT_VALID(result);
 
   result = Dart_Invoke(lib, NewString("testMain"), 0, NULL);
   EXPECT_VALID(result);
   EXPECT(Dart_IsInteger(result));
@@ skipping 119 matching lines @@
       "  Expect.equals(3, obj.bar42(1, 1));\n"
       "  Expect.equals(6, Test.foo4(2, 2, 2));\n"
       "  Expect.equals(6, obj.bar43(2, 2, 2));\n"
       "\n"
       "  return 0;\n"
       "}\n";
 
   Dart_Handle result;
 
   // Load a test script.
-  Dart_Handle url = NewString(TestCase::url());
-  Dart_Handle source = NewString(kScriptChars);
-  result = Dart_SetLibraryTagHandler(library_handler);
-  EXPECT_VALID(result);
-  Dart_Handle lib = Dart_LoadScript(url, Dart_Null(), source, 0, 0);
+  Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
   EXPECT_VALID(lib);
   EXPECT(Dart_IsLibrary(lib));
   result = Dart_SetNativeResolver(lib, &MyStaticNativeClosureResolver, NULL);
   EXPECT_VALID(result);
   result = Dart_FinalizeLoading(false);
   EXPECT_VALID(result);
 
   result = Dart_Invoke(lib, NewString("testMain"), 0, NULL);
   EXPECT_VALID(result);
   EXPECT(Dart_IsInteger(result));
@@ skipping 1835 matching lines @@
   EXPECT_VALID(result);
   result = Dart_FinalizeLoading(false);
   EXPECT_VALID(result);
   result = Dart_Invoke(lib, NewString("foozoo"), 0, NULL);
   EXPECT(Dart_IsError(result));
 }
 
 #endif  // !PRODUCT
 
 }  // namespace dart