Making AudioInputDeviceManager to return UnavailableDeviceParameters when there are no physical inp…

Making AudioInputDeviceManager to return UnavailableDeviceParameters when there are no physical input devices.

BUG=733356
Review-Url: https://codereview.chromium.org/2948233002
Cr-Commit-Position: refs/heads/master@{#481510}
Committed: https://chromium.googlesource.com/chromium/src/+/d9a4e3e3f860fb848ce36deea29f0d685c6d81c6

[o1ka, 2017-06-22 09:32:33]

olka@chromium.org changed reviewers:
+ guidou@chromium.org

[o1ka, 2017-06-22 09:32:34]

Guido PTAL

https://codereview.chromium.org/2948233002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/media/audio_input_device_manager.cc (right):

https://codereview.chromium.org/2948233002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/media/audio_input_device_manager.cc:79:
switches::kUseFakeDeviceForMediaStream)) {
Alternatively we may check here if device.type is MEDIA_TAB_AUDIO_CAPTURE and
fallback to unavailable device parameters immediately. But this would change the
current behavior of returning real input device parameters for
MEDIA_TAB_AUDIO_CAPTURE device if physical input device exists.

[Guido Urdaneta, 2017-06-22 09:37:17]

lgtm % nit

https://codereview.chromium.org/2948233002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/media/audio_input_device_manager.cc (right):

https://codereview.chromium.org/2948233002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/media/audio_input_device_manager.cc:171:
media::AudioParameters valid_input_params(
nit: Use assignment syntax instead.

[o1ka, 2017-06-22 09:44:34]

The CQ bit was checked by olka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 09:44:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 10:56:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 10:56:42]

Dry run: This issue passed the CQ dry run.

[o1ka, 2017-06-22 12:39:20]

The CQ bit was checked by olka@chromium.org

[o1ka, 2017-06-22 12:39:21]

The patchset sent to the CQ was uploaded after l-g-t-m from guidou@chromium.org
Link to the patchset: https://codereview.chromium.org/2948233002/#ps20001
(title: "nit fix")

[commit-bot: I haz the power, 2017-06-22 12:39:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[o1ka, 2017-06-22 12:39:41]

On 2017/06/22 09:37:17, Guido Urdaneta wrote:
> lgtm % nit
> 
>
https://codereview.chromium.org/2948233002/diff/1/content/browser/renderer_ho...
> File content/browser/renderer_host/media/audio_input_device_manager.cc
(right):
> 
>
https://codereview.chromium.org/2948233002/diff/1/content/browser/renderer_ho...
> content/browser/renderer_host/media/audio_input_device_manager.cc:171:
> media::AudioParameters valid_input_params(
> nit: Use assignment syntax instead.

Thanks, fixed.

[commit-bot: I haz the power, 2017-06-22 12:42:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498135160729630,
"parent_rev": "cb0be855771dede26a06e0378eadf6ce31c1efb1", "commit_rev":
"d9a4e3e3f860fb848ce36deea29f0d685c6d81c6"}

[commit-bot: I haz the power, 2017-06-22 12:42:52]

Description was changed from

==========
Making AudioInputDeviceManager to return UnavailableDeviceParameters when there
are no physical input devices.

BUG=733356
==========

to

==========
Making AudioInputDeviceManager to return UnavailableDeviceParameters when there
are no physical input devices.

BUG=733356

Review-Url: https://codereview.chromium.org/2948233002
Cr-Commit-Position: refs/heads/master@{#481510}
Committed:
https://chromium.googlesource.com/chromium/src/+/d9a4e3e3f860fb848ce36deea29f...
==========

[commit-bot: I haz the power, 2017-06-22 12:42:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d9a4e3e3f860fb848ce36deea29f...