Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2948223002: Revert of Do not activate TrayBubbleView by default (Closed)

Created:
3 years, 6 months ago by vabr (Chromium)
Modified:
3 years, 6 months ago
CC:
chromium-reviews, groby+bubble_chromium.org, sadrul, tfarina, hcarmona+bubble_chromium.org, kalyank, rouslan+bubble_chromium.org, oshima, yoshiki, yhanada
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Do not activate TrayBubbleView by default (patchset #15 id:270001 of https://codereview.chromium.org/2897553002/ ) Reason for revert: Speculative revert. I suspect this broke the interactive_ui_tests on Linux ChromiumOS MSan Tests (https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/1276). The tests now time out, and the log contains lines with: Still waiting for the following processes to finish: ./interactive_ui_tests --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=TestAsNormalAndGuestUser/SpokenFeedbackTest.NavigateSystemTray/0 --single_process --test-launcher-bot-mode --test-launcher-print-test-stdio=always --test-launcher-summary-output=/b/s/w/ioS9oZeu/output.json --user-data-dir=/b/s/w/it1bN0Em/.org.chromium.Chromium.iOqw8e/dOj481Q Original issue's description: > Do not activate TrayBubbleView by default > > - Activating a TrayBubbleView brings an Android window to onPause state. > - This CL sets can_set_activate to false and makes TrayBubbleView not > activated by default. > - If the TrayBubbleView is not activated, it cannot capture key events > for moving focus or closing the view by keyboard. TrayBubbleView tries > to register accelerators at the global level to capture those key > events. > - Activates the TrayBubbleView by default if keyboard navigation > accessibility feature (e.g. spoken feedback) is enabled. > > BUG=726588, 731748 > TEST=Follow steps described in the issue > > Review-Url: https://codereview.chromium.org/2897553002 > Cr-Commit-Position: refs/heads/master@{#481421} > Committed: https://chromium.googlesource.com/chromium/src/+/c97f341f1a2f6f359ba1a7c8687aa58af6f7033c TBR=stevenjb@chromium.org,dmazzoni@chromium.org,msw@chromium.org,jamescook@chromium.org,yawano@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=726588, 731748 Review-Url: https://codereview.chromium.org/2948223002 Cr-Commit-Position: refs/heads/master@{#481485} Committed: https://chromium.googlesource.com/chromium/src/+/0cafb5aa2544670f4313e102e3ff12225dc5dafa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -220 lines) Patch
M ash/system/ime_menu/ime_menu_tray.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ash/system/ime_menu/ime_menu_tray.cc View 4 chunks +2 lines, -18 lines 0 comments Download
M ash/system/palette/palette_tray.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ash/system/palette/palette_tray.cc View 4 chunks +2 lines, -19 lines 0 comments Download
M ash/system/tray/system_tray.h View 4 chunks +7 lines, -5 lines 0 comments Download
M ash/system/tray/system_tray.cc View 9 chunks +37 lines, -24 lines 0 comments Download
M ash/system/tray/system_tray_bubble.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/system/tray/system_tray_bubble.cc View 2 chunks +12 lines, -1 line 0 comments Download
M ash/system/web_notification/web_notification_tray.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 3 chunks +1 line, -18 lines 0 comments Download
M ui/message_center/views/message_bubble_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/bubble/tray_bubble_view.h View 6 chunks +3 lines, -32 lines 0 comments Download
M ui/views/bubble/tray_bubble_view.cc View 7 chunks +3 lines, -87 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
vabr (Chromium)
Created Revert of Do not activate TrayBubbleView by default
3 years, 6 months ago (2017-06-22 09:02:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2948223002/1
3 years, 6 months ago (2017-06-22 09:02:52 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 09:03:49 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0cafb5aa2544670f4313e102e3ff...

Powered by Google App Engine
This is Rietveld 408576698