Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2948183002: DevTools: remove TestRunner.loadLazyModules (Closed)

Created:
3 years, 6 months ago by chenwilliam
Modified:
3 years, 6 months ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: remove TestRunner.loadLazyModules Migrate call sites to TestRunner.loadModule. Very few tests need to directly load multiple lazy modules. BUG=667560 Review-Url: https://codereview.chromium.org/2948183002 Cr-Commit-Position: refs/heads/master@{#481637} Committed: https://chromium.googlesource.com/chromium/src/+/d902dcf5ff90085acf753d9b075e7f778d0c4167

Patch Set 1 #

Messages

Total messages: 12 (6 generated)
chenwilliam
ptal. also f/u work from the test infra CL.
3 years, 6 months ago (2017-06-22 00:03:33 UTC) #2
dgozman
lgtm
3 years, 6 months ago (2017-06-22 00:11:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2948183002/1
3 years, 6 months ago (2017-06-22 00:16:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/473418)
3 years, 6 months ago (2017-06-22 04:42:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2948183002/1
3 years, 6 months ago (2017-06-22 17:30:04 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 19:57:40 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d902dcf5ff90085acf753d9b075e...

Powered by Google App Engine
This is Rietveld 408576698