Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2948083002: MacViews: Use the Aura color for prominent button backgrounds. (Closed)

Created:
3 years, 6 months ago by tapted
Modified:
3 years, 6 months ago
CC:
chromium-reviews, mac-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Use the Aura color for prominent button backgrounds. Do this even without --secondary-ui-md, since we blacklisted non-MD dialog buttons for secondary UI in r478352. NSColor doesn't offer a color for prominent buttons. Use the Aura color, but apply the system tint. This is a good match for the blue Cocoa uses to draw buttons that are given a \n key equivalent. BUG=732889 Review-Url: https://codereview.chromium.org/2948083002 Cr-Commit-Position: refs/heads/master@{#481744} Committed: https://chromium.googlesource.com/chromium/src/+/2fad1a80b82ed7df3a3967192a07d8f55e1bab0a

Patch Set 1 #

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ui/native_theme/native_theme_mac.mm View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
tapted
Hi Elly, please take a look
3 years, 6 months ago (2017-06-21 11:10:28 UTC) #7
Elly Fong-Jones
lgtm :)
3 years, 6 months ago (2017-06-22 14:13:04 UTC) #8
tapted
+pkasting for ui/native_theme OWNERS - ptal thanks!
3 years, 6 months ago (2017-06-22 23:52:15 UTC) #10
Peter Kasting
LGTM
3 years, 6 months ago (2017-06-22 23:55:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2948083002/20001
3 years, 6 months ago (2017-06-22 23:56:08 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 00:27:44 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2fad1a80b82ed7df3a3967192a07...

Powered by Google App Engine
This is Rietveld 408576698