Issue 2948063002: Null check FocusedFrame in spatial navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2948063002: Null check FocusedFrame in spatial navigation (Closed)

Created:
3 years, 6 months ago by kochi

Modified:
3 years, 6 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3112

Project:
chromium

Visibility:
Public.

Null check FocusedFrame in spatial navigation Fixes null pointer dereference. Bug: 732936 Change-Id: I4ffc475dba4f0268faaaa7720ac27558d73ce8bb Reviewed-on: https://chromium-review.googlesource.com/539358 Reviewed-by: Kent Tamura <tkent@chromium.org>; Commit-Queue: Takayoshi Kochi <kochi@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#480691} Review-Url: https://codereview.chromium.org/2948063002 . Cr-Commit-Position: refs/branch-heads/3112@{#419} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/5d015f9c3212d7ed28f55a875a09f0c398a1cef4

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	third_party/WebKit/Source/core/page/FocusController.cpp	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

kochi

3 years, 6 months ago (2017-06-21 08:35:45 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5d015f9c3212d7ed28f55a875a09f0c398a1cef4.