Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2948033005: cc: Drop locked decodes from checker image tracker on cache switch. (Closed)

Created:
3 years, 6 months ago by Khushal
Modified:
3 years, 6 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Drop locked decodes from checker image tracker on cache switch. When switching from gpu<->software caches, the checker tracker assumes it has a valid decode, but it doesn't since the decode cache itself is destroyed. So ask the tracker to drop its decodes as well. R=vmpstr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2948033005 Cr-Commit-Position: refs/heads/master@{#481676} Committed: https://chromium.googlesource.com/chromium/src/+/65e261992e4c00c6c97fae8d13ebb784f0e88cfa

Patch Set 1 #

Patch Set 2 : .. #

Patch Set 3 : tested #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -0 lines) Patch
M cc/tiles/checker_image_tracker.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M cc/tiles/tile_manager.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M cc/tiles/tile_manager_unittest.cc View 1 2 2 chunks +50 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Khushal
3 years, 6 months ago (2017-06-22 09:02:01 UTC) #2
vmpstr
lgtm, if possible can you add a test?
3 years, 6 months ago (2017-06-22 16:43:03 UTC) #3
Khushal
On 2017/06/22 16:43:03, vmpstr wrote: > lgtm, if possible can you add a test? Done. ...
3 years, 6 months ago (2017-06-22 20:32:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2948033005/40001
3 years, 6 months ago (2017-06-22 20:32:52 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 21:53:17 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/65e261992e4c00c6c97fae8d13eb...

Powered by Google App Engine
This is Rietveld 408576698