Add a second format to the tracing json/begin_recording endpoint.

Add a second format to the tracing json/begin_recording endpoint.

The previous format was unspecified, untested, and using the older
category_filters format. This is incompatible with the newer included/excluded
categories format.

The new format is the same as the TraceConfig format. This CL also adds tests.

BUG=chromium:735124
Review-Url: https://codereview.chromium.org/2948033004
Cr-Commit-Position: refs/heads/master@{#481662}
Committed: https://chromium.googlesource.com/chromium/src/+/3e164f76405e21777fae49bd221e8d86e7df4bfd

[erikchen, 2017-06-21 22:05:00]

Description was changed from

==========
Add a second format to the tracing json/begin_recording? endpoint.

The previous format was unspecified, untested, and using the older
category_filters format. This is incompatible with the newer included/excluded
categories format.

The new format is the same as the TraceConfig format. This CL also adds tests.

BUG=chromium:735124
==========

to

==========
Add a second format to the tracing json/begin_recording endpoint.

The previous format was unspecified, untested, and using the older
category_filters format. This is incompatible with the newer included/excluded
categories format.

The new format is the same as the TraceConfig format. This CL also adds tests.

BUG=chromium:735124
==========

[erikchen, 2017-06-21 22:05:58]

erikchen@chromium.org changed reviewers:
+ primiano@chromium.org, ssid@chromium.org

[erikchen, 2017-06-21 22:05:59]

ssid, primiano: Please review.

[erikchen, 2017-06-21 22:06:04]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 22:06:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[erikchen, 2017-06-21 22:16:20]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 22:16:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ssid, 2017-06-21 22:30:10]

lgtm

[commit-bot: I haz the power, 2017-06-21 22:59:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 22:59:52]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Primiano Tucci (use gerrit), 2017-06-22 19:04:47]

LGTM. Not sure why the linker is unhappy on component builds (see chat on slack)

https://codereview.chromium.org/2948033004/diff/20001/content/browser/tracing...
File content/browser/tracing/tracing_ui.h (right):

https://codereview.chromium.org/2948033004/diff/20001/content/browser/tracing...
content/browser/tracing/tracing_ui.h:37: static bool GetTracingOptions(const
std::string& data64,
static functions should go on the top. But also if this is the only change here,
not worth the hassle of another patchset.

[erikchen, 2017-06-22 19:30:45]

https://codereview.chromium.org/2948033004/diff/20001/content/browser/tracing...
File content/browser/tracing/tracing_ui.h (right):

https://codereview.chromium.org/2948033004/diff/20001/content/browser/tracing...
content/browser/tracing/tracing_ui.h:37: static bool GetTracingOptions(const
std::string& data64,
On 2017/06/22 19:04:47, Primiano Tucci wrote:
> static functions should go on the top. But also if this is the only change
here,
> not worth the hassle of another patchset.

Done.

[erikchen, 2017-06-22 19:31:02]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2017-06-22 19:31:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org, ssid@chromium.org
Link to the patchset: https://codereview.chromium.org/2948033004/#ps40001
(title: "don't compile test on android.")

[commit-bot: I haz the power, 2017-06-22 19:31:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 19:36:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 19:36:33]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[erikchen, 2017-06-22 19:43:57]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2017-06-22 19:43:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org, ssid@chromium.org
Link to the patchset: https://codereview.chromium.org/2948033004/#ps60001
(title: "fix gn config.")

[commit-bot: I haz the power, 2017-06-22 19:44:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 21:15:49]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498160637141180,
"parent_rev": "14072aff84d5ba7298a8e61be8dba95fa209c112", "commit_rev":
"3e164f76405e21777fae49bd221e8d86e7df4bfd"}

[commit-bot: I haz the power, 2017-06-22 21:16:02]

Description was changed from

==========
Add a second format to the tracing json/begin_recording endpoint.

The previous format was unspecified, untested, and using the older
category_filters format. This is incompatible with the newer included/excluded
categories format.

The new format is the same as the TraceConfig format. This CL also adds tests.

BUG=chromium:735124
==========

to

==========
Add a second format to the tracing json/begin_recording endpoint.

The previous format was unspecified, untested, and using the older
category_filters format. This is incompatible with the newer included/excluded
categories format.

The new format is the same as the TraceConfig format. This CL also adds tests.

BUG=chromium:735124

Review-Url: https://codereview.chromium.org/2948033004
Cr-Commit-Position: refs/heads/master@{#481662}
Committed:
https://chromium.googlesource.com/chromium/src/+/3e164f76405e21777fae49bd221e...
==========

[commit-bot: I haz the power, 2017-06-22 21:16:04]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3e164f76405e21777fae49bd221e...