Chromium Code Reviews| Index: tracing/tracing/ui/extras/about_tracing/record_controller.html |
| diff --git a/tracing/tracing/ui/extras/about_tracing/record_controller.html b/tracing/tracing/ui/extras/about_tracing/record_controller.html |
| index a759330e6646307a4b5256a5b73f00ad3f92467c..09388b2aa357e63682e8deef7584e0928f4c102f 100644 |
| --- a/tracing/tracing/ui/extras/about_tracing/record_controller.html |
| +++ b/tracing/tracing/ui/extras/about_tracing/record_controller.html |
| @@ -85,14 +85,14 @@ tr.exportTo('tr.ui.e.about_tracing', function() { |
| }; |
| Polymer.dom(progressDlg).appendChild(stopButton); |
| + const categories = selectionDlg.includedAndExcludedCategories(); |
| const recordingOptions = { |
| - categoryFilter: selectionDlg.categoryFilter(), |
|
ssid
2017/06/21 18:59:20
This line should not be removed. This is used by o
erikchen
2017/06/21 22:56:50
There's only 1 other client . iswitched it to also
|
| + includedCategories: categories.included, |
| + excludedCategories: categories.excluded, |
| useSystemTracing: selectionDlg.useSystemTracing, |
| tracingRecordMode: selectionDlg.tracingRecordMode, |
| - useSampling: selectionDlg.useSampling |
|
ssid
2017/06/21 18:59:20
I think we should keep this. I am not sure if any
erikchen
2017/06/21 22:56:50
Let's not keep dead code.
fmeawad
2017/06/22 23:16:39
sampling is to be removed everywhere. Thanks for t
|
| }; |
| - |
| const requestPromise = tracingControllerClient.beginRecording( |
| recordingOptions); |
| requestPromise.then( |