Chromium Code Reviews Chromium Code Reviews
Issue 2948023002:
Fix periodic dumping for memory-infra on Android. (Closed)
| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <!-- | 2 <!-- |
| 3 Copyright (c) 2013 The Chromium Authors. All rights reserved. | 3 Copyright (c) 2013 The Chromium Authors. All rights reserved. |
| 4 Use of this source code is governed by a BSD-style license that can be | 4 Use of this source code is governed by a BSD-style license that can be |
| 5 found in the LICENSE file. | 5 found in the LICENSE file. |
| 6 --> | 6 --> |
| 7 | 7 |
| 8 <link rel="import" href="/tracing/ui/extras/about_tracing/record_selection_dialo g.html"> | 8 <link rel="import" href="/tracing/ui/extras/about_tracing/record_selection_dialo g.html"> |
| 9 | 9 |
| 10 <script> | 10 <script> |
| (...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 78 bufferPercentFullDiv = document.createElement('div'); | 78 bufferPercentFullDiv = document.createElement('div'); |
| 79 Polymer.dom(progressDlg).appendChild(bufferPercentFullDiv); | 79 Polymer.dom(progressDlg).appendChild(bufferPercentFullDiv); |
| 80 | 80 |
| 81 const stopButton = document.createElement('button'); | 81 const stopButton = document.createElement('button'); |
| 82 Polymer.dom(stopButton).textContent = 'Stop'; | 82 Polymer.dom(stopButton).textContent = 'Stop'; |
| 83 progressDlg.clickStopButton = function() { | 83 progressDlg.clickStopButton = function() { |
| 84 stopButton.click(); | 84 stopButton.click(); |
| 85 }; | 85 }; |
| 86 Polymer.dom(progressDlg).appendChild(stopButton); | 86 Polymer.dom(progressDlg).appendChild(stopButton); |
| 87 | 87 |
| 88 const categories = selectionDlg.includedAndExcludedCategories(); | |
| 88 const recordingOptions = { | 89 const recordingOptions = { |
| 89 categoryFilter: selectionDlg.categoryFilter(), | 90 includedCategories: categories.included, |
|
ssid
2017/06/21 18:59:20
This line should not be removed. This is used by o
erikchen
2017/06/21 22:56:50
There's only 1 other client . iswitched it to also
| |
| 91 excludedCategories: categories.excluded, | |
| 90 useSystemTracing: selectionDlg.useSystemTracing, | 92 useSystemTracing: selectionDlg.useSystemTracing, |
| 91 tracingRecordMode: selectionDlg.tracingRecordMode, | 93 tracingRecordMode: selectionDlg.tracingRecordMode, |
| 92 useSampling: selectionDlg.useSampling | |
|
ssid
2017/06/21 18:59:20
I think we should keep this. I am not sure if any
erikchen
2017/06/21 22:56:50
Let's not keep dead code.
fmeawad
2017/06/22 23:16:39
sampling is to be removed everywhere. Thanks for t
| |
| 93 }; | 94 }; |
| 94 | 95 |
| 95 | |
| 96 const requestPromise = tracingControllerClient.beginRecording( | 96 const requestPromise = tracingControllerClient.beginRecording( |
| 97 recordingOptions); | 97 recordingOptions); |
| 98 requestPromise.then( | 98 requestPromise.then( |
| 99 function() { | 99 function() { |
| 100 progressDlg.visible = true; | 100 progressDlg.visible = true; |
| 101 stopButton.focus(); | 101 stopButton.focus(); |
| 102 updateBufferPercentFull('0'); | 102 updateBufferPercentFull('0'); |
| 103 }, | 103 }, |
| 104 recordFailed); | 104 recordFailed); |
| 105 | 105 |
| (...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 171 __proto__: Error.prototype | 171 __proto__: Error.prototype |
| 172 }; | 172 }; |
| 173 | 173 |
| 174 return { | 174 return { |
| 175 beginRecording, | 175 beginRecording, |
| 176 UserCancelledError, | 176 UserCancelledError, |
| 177 defaultTraceName, | 177 defaultTraceName, |
| 178 }; | 178 }; |
| 179 }); | 179 }); |
| 180 </script> | 180 </script> |
| OLD | NEW |
