Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2948003003: Inline PlatformThreadLocalStorage::GetTLSValue (Closed)

Created:
3 years, 6 months ago by hans
Modified:
3 years, 6 months ago
Reviewers:
Nico, dcheng
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Inline PlatformThreadLocalStorage::GetTLSValue This is hit frequently, and would benefit from inlining even in non-LTO builds (see bug). BUG=728324 Review-Url: https://codereview.chromium.org/2948003003 Cr-Commit-Position: refs/heads/master@{#481093} Committed: https://chromium.googlesource.com/chromium/src/+/56e130ab164dbd2949c0355a273d97d0c9d0d4a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M base/threading/thread_local_storage.h View 1 chunk +7 lines, -1 line 0 comments Download
M base/threading/thread_local_storage_posix.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M base/threading/thread_local_storage_win.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
hans
Please take a look.
3 years, 6 months ago (2017-06-21 00:22:08 UTC) #3
dcheng
lgtm
3 years, 6 months ago (2017-06-21 00:29:37 UTC) #5
Nico
lgtm
3 years, 6 months ago (2017-06-21 00:51:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2948003003/1
3 years, 6 months ago (2017-06-21 00:52:56 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 02:54:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/56e130ab164dbd2949c0355a273d...

Powered by Google App Engine
This is Rietveld 408576698