Fix style issues for right-to-left languages

Fix style issues for right-to-left languages

crbug.com/733024 is actually a CSS style issue. This CL also fixes other
obvious style issues for right-to-left languages. We may need to further
polish the UI for rtl languages and those changes will be included in
a specific polish CL.

BUG=733024
Review-Url: https://codereview.chromium.org/2947933002
Cr-Commit-Position: refs/heads/master@{#480951}
Committed: https://chromium.googlesource.com/chromium/src/+/5b7f6444e266ac72eefee3386e67dadca1b234cc

[Wenzhao (Colin) Zang, 2017-06-20 18:46:56]

Description was changed from

==========
Fix style issues for right-to-left languages

BUG=733024
==========

to

==========
Fix style issues for right-to-left languages

crbug.com/733024 is actually a CSS style issue. This CL also fixes other
obvious style issues for right-to-left languages. We may need to further
polish the UI for rtl languages and those changes will be included in
a specific polish CL.

BUG=733024
==========

[Wenzhao (Colin) Zang, 2017-06-20 18:46:56]

wzang@chromium.org changed reviewers:
+ jdufault@chromium.org, xiyuan@chromium.org

[Wenzhao (Colin) Zang, 2017-06-20 18:59:13]

The CQ bit was checked by wzang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 18:59:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiyuan, 2017-06-20 19:14:36]

lgtm with one nit

https://codereview.chromium.org/2947933002/diff/1/ui/login/account_picker/md_...
File ui/login/account_picker/md_user_pod_row.js (right):

https://codereview.chromium.org/2947933002/diff/1/ui/login/account_picker/md_...
ui/login/account_picker/md_user_pod_row.js:3976: switchDirection_: function(el)
{
nit: Move this out of the class, similar to removeClass, since it is a generic
helper rather than a class specific method.

[commit-bot: I haz the power, 2017-06-20 19:23:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 19:23:03]

Dry run: This issue passed the CQ dry run.

[Wenzhao (Colin) Zang, 2017-06-20 20:20:02]

The CQ bit was checked by wzang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 20:20:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 20:42:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 20:42:37]

Dry run: This issue passed the CQ dry run.

[Wenzhao (Colin) Zang, 2017-06-20 20:43:09]

The CQ bit was checked by wzang@chromium.org

[Wenzhao (Colin) Zang, 2017-06-20 20:43:09]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2947933002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2017-06-20 20:43:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Wenzhao (Colin) Zang, 2017-06-20 20:43:50]

https://codereview.chromium.org/2947933002/diff/1/ui/login/account_picker/md_...
File ui/login/account_picker/md_user_pod_row.js (right):

https://codereview.chromium.org/2947933002/diff/1/ui/login/account_picker/md_...
ui/login/account_picker/md_user_pod_row.js:3976: switchDirection_: function(el)
{
On 2017/06/20 19:14:36, xiyuan wrote:
> nit: Move this out of the class, similar to removeClass, since it is a generic
> helper rather than a class specific method.

Done.

[commit-bot: I haz the power, 2017-06-20 20:48:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497991389136760,
"parent_rev": "510566d5056c8b71c2ede25e6509c3186d762590", "commit_rev":
"5b7f6444e266ac72eefee3386e67dadca1b234cc"}

[commit-bot: I haz the power, 2017-06-20 20:48:32]

Description was changed from

==========
Fix style issues for right-to-left languages

crbug.com/733024 is actually a CSS style issue. This CL also fixes other
obvious style issues for right-to-left languages. We may need to further
polish the UI for rtl languages and those changes will be included in
a specific polish CL.

BUG=733024
==========

to

==========
Fix style issues for right-to-left languages

crbug.com/733024 is actually a CSS style issue. This CL also fixes other
obvious style issues for right-to-left languages. We may need to further
polish the UI for rtl languages and those changes will be included in
a specific polish CL.

BUG=733024

Review-Url: https://codereview.chromium.org/2947933002
Cr-Commit-Position: refs/heads/master@{#480951}
Committed:
https://chromium.googlesource.com/chromium/src/+/5b7f6444e266ac72eefee3386e67...
==========

[commit-bot: I haz the power, 2017-06-20 20:48:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5b7f6444e266ac72eefee3386e67...