Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2947933002: Fix style issues for right-to-left languages (Closed)

Created:
3 years, 6 months ago by Wenzhao (Colin) Zang
Modified:
3 years, 6 months ago
Reviewers:
xiyuan, jdufault
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix style issues for right-to-left languages crbug.com/733024 is actually a CSS style issue. This CL also fixes other obvious style issues for right-to-left languages. We may need to further polish the UI for rtl languages and those changes will be included in a specific polish CL. BUG=733024 Review-Url: https://codereview.chromium.org/2947933002 Cr-Commit-Position: refs/heads/master@{#480951} Committed: https://chromium.googlesource.com/chromium/src/+/5b7f6444e266ac72eefee3386e67dadca1b234cc

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -29 lines) Patch
M ui/login/account_picker/md_user_pod_row.css View 14 chunks +34 lines, -26 lines 0 comments Download
M ui/login/account_picker/md_user_pod_row.js View 1 6 chunks +35 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
Wenzhao (Colin) Zang
3 years, 6 months ago (2017-06-20 18:47:12 UTC) #3
xiyuan
lgtm with one nit https://codereview.chromium.org/2947933002/diff/1/ui/login/account_picker/md_user_pod_row.js File ui/login/account_picker/md_user_pod_row.js (right): https://codereview.chromium.org/2947933002/diff/1/ui/login/account_picker/md_user_pod_row.js#newcode3976 ui/login/account_picker/md_user_pod_row.js:3976: switchDirection_: function(el) { nit: Move ...
3 years, 6 months ago (2017-06-20 19:14:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2947933002/20001
3 years, 6 months ago (2017-06-20 20:43:38 UTC) #15
Wenzhao (Colin) Zang
https://codereview.chromium.org/2947933002/diff/1/ui/login/account_picker/md_user_pod_row.js File ui/login/account_picker/md_user_pod_row.js (right): https://codereview.chromium.org/2947933002/diff/1/ui/login/account_picker/md_user_pod_row.js#newcode3976 ui/login/account_picker/md_user_pod_row.js:3976: switchDirection_: function(el) { On 2017/06/20 19:14:36, xiyuan wrote: > ...
3 years, 6 months ago (2017-06-20 20:43:50 UTC) #16
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 20:48:34 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5b7f6444e266ac72eefee3386e67...

Powered by Google App Engine
This is Rietveld 408576698