Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 2947903002: PPC/s390: [compiler] Drive optimizations with feedback vector (reland) (Closed)

Created:
3 years, 6 months ago by john.yan
Modified:
3 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [compiler] Drive optimizations with feedback vector (reland) Port 24b7026d738415da9ccfb058ca0e27d133635beb Original Commit Message: For interpreted functions, use the optimized code slot in the feedback vector to store an optimization marker (optimize/in optimization queue) rather than changing the JSFunction's code object. Then, adapt the self-healing mechanism to also dispatch based on this optimization marker. Similarly, replace SFI marking with optimization marker checks in CompileLazy. This allows JSFunctions to share optimization information (replacing shared function marking) without leaking this information across native contexts. Non I+TF functions (asm.js or --no-turbo) use a CheckOptimizationMarker shim which generalises the old CompileOptimized/InOptimizationQueue builtins and also checks the same optimization marker as CompileLazy and InterpreterEntryTrampoline. This is a reland of https://chromium-review.googlesource.com/c/509716 R=leszeks@chromium.org, joransiu@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2947903002 Cr-Commit-Position: refs/heads/master@{#46109} Committed: https://chromium.googlesource.com/v8/v8/+/43f1461255d7073157d08f90d0d01493e9a862c0

Patch Set 1 #

Patch Set 2 : fix ppc issue and upload s390 port #

Patch Set 3 : fix ppc issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+362 lines, -218 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 1 2 9 chunks +183 lines, -109 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 1 9 chunks +179 lines, -109 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
john.yan
PTAL
3 years, 6 months ago (2017-06-21 19:38:10 UTC) #1
JaideepBajwa
lgtm
3 years, 6 months ago (2017-06-21 19:39:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2947903002/40001
3 years, 6 months ago (2017-06-21 19:48:57 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/27938) v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
3 years, 6 months ago (2017-06-21 20:52:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2947903002/40001
3 years, 6 months ago (2017-06-21 21:04:56 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 22:12:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/43f1461255d7073157d08f90d0d01493e9a...

Powered by Google App Engine
This is Rietveld 408576698