Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2947863003: Make RefCountedThreadSafeBase::AddRef and Release available for inlining (Closed)

Created:
3 years, 6 months ago by hans
Modified:
3 years, 6 months ago
Reviewers:
Nico, dcheng
CC:
chromium-reviews, danakj+watch_chromium.org, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make RefCountedThreadSafeBase::AddRef and Release available for inlining These are hit frequently, and would benefit from inlining even in non-LTO builds (see bug). BUG=728324 Review-Url: https://codereview.chromium.org/2947863003 Cr-Commit-Position: refs/heads/master@{#481091} Committed: https://chromium.googlesource.com/chromium/src/+/5e3bdec771619fd558e176dafe393bfe1690078a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -27 lines) Patch
M base/memory/ref_counted.h View 1 chunk +23 lines, -2 lines 0 comments Download
M base/memory/ref_counted.cc View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
hans
Please take a look.
3 years, 6 months ago (2017-06-21 00:02:21 UTC) #2
Nico
Lgtm I guess with dchecks off this should at worst be size neutral?
3 years, 6 months ago (2017-06-21 00:19:41 UTC) #5
dcheng
lgtm
3 years, 6 months ago (2017-06-21 00:29:01 UTC) #6
hans
On 2017/06/21 00:19:41, Nico wrote: > Lgtm > > I guess with dchecks off this ...
3 years, 6 months ago (2017-06-21 00:31:53 UTC) #7
hans
I did an official release build on linux, and it saved about 4 KB :-)
3 years, 6 months ago (2017-06-21 01:00:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2947863003/1
3 years, 6 months ago (2017-06-21 01:01:13 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 02:40:54 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5e3bdec771619fd558e176dafe39...

Powered by Google App Engine
This is Rietveld 408576698