[Extensions Bindings] Introduce BindingAccessChecker

[Extensions Bindings] Introduce BindingAccessChecker

Add a new class, BindingAccessChecker, to handle checking for access to
a given feature and optionally throwing an error if access is forbidden.
Currently, this is only used in APIBinding, but a followup will expand
its usage.

Add tests for the same.

BUG=653596
Review-Url: https://codereview.chromium.org/2947843004
Cr-Commit-Position: refs/heads/master@{#481453}
Committed: https://chromium.googlesource.com/chromium/src/+/406dff52dcdcd355988cbf2be9070d97bc45b633

[Devlin, 2017-06-20 21:24:00]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 21:24:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2017-06-20 21:25:18]

Description was changed from

==========
access checker
BUG=
==========

to

==========
[Extensions Bindings] Introduce BindingAccessChecker

Add a new class, BindingAccessChecker, to handle checking for access to
a given feature and optionally throwing an error if access is forbidden.
Currently, this is only used in APIBinding, but a followup will expand
its usage.

Add tests for the same.

BUG=653596
==========

[commit-bot: I haz the power, 2017-06-20 22:56:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 22:56:35]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-06-20 23:02:58]

rdevlin.cronin@chromium.org changed reviewers:
+ jbroman@chromium.org, lazyboy@chromium.org

[Devlin, 2017-06-20 23:02:59]

Hey folks, mind taking a look?

[jbroman, 2017-06-20 23:33:51]

lgtm

[lazyboy, 2017-06-22 00:14:21]

lgtm

https://codereview.chromium.org/2947843004/diff/20001/extensions/renderer/api...
File extensions/renderer/api_binding.h (right):

https://codereview.chromium.org/2947843004/diff/20001/extensions/renderer/api...
extensions/renderer/api_binding.h:149: const BindingAccessChecker*
access_checker_;
const T* const access_checker_...

[Devlin, 2017-06-22 00:22:13]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 00:22:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2017-06-22 01:21:28]

https://codereview.chromium.org/2947843004/diff/20001/extensions/renderer/api...
File extensions/renderer/api_binding.h (right):

https://codereview.chromium.org/2947843004/diff/20001/extensions/renderer/api...
extensions/renderer/api_binding.h:149: const BindingAccessChecker*
access_checker_;
On 2017/06/22 00:14:21, lazyboy wrote:
> const T* const access_checker_...

Sure, done.

[Devlin, 2017-06-22 01:21:44]

The CQ bit was unchecked by rdevlin.cronin@chromium.org

[Devlin, 2017-06-22 01:22:08]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2017-06-22 01:22:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
lazyboy@chromium.org, jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2947843004/#ps40001
(title: "lazyboy's")

[commit-bot: I haz the power, 2017-06-22 01:22:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 04:21:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 04:21:13]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2017-06-22 04:58:02]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2017-06-22 04:58:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 05:45:14]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498107482648110,
"parent_rev": "d90fcdc0b6810e28ed0970f76c69583cb686c90a", "commit_rev":
"406dff52dcdcd355988cbf2be9070d97bc45b633"}

[commit-bot: I haz the power, 2017-06-22 05:45:28]

Description was changed from

==========
[Extensions Bindings] Introduce BindingAccessChecker

Add a new class, BindingAccessChecker, to handle checking for access to
a given feature and optionally throwing an error if access is forbidden.
Currently, this is only used in APIBinding, but a followup will expand
its usage.

Add tests for the same.

BUG=653596
==========

to

==========
[Extensions Bindings] Introduce BindingAccessChecker

Add a new class, BindingAccessChecker, to handle checking for access to
a given feature and optionally throwing an error if access is forbidden.
Currently, this is only used in APIBinding, but a followup will expand
its usage.

Add tests for the same.

BUG=653596

Review-Url: https://codereview.chromium.org/2947843004
Cr-Commit-Position: refs/heads/master@{#481453}
Committed:
https://chromium.googlesource.com/chromium/src/+/406dff52dcdcd355988cbf2be907...
==========

[commit-bot: I haz the power, 2017-06-22 05:45:29]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/406dff52dcdcd355988cbf2be907...