Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2947533002: Potentially do less work in PDFiumEngine::CreateSinglePageRasterPdf(). (Closed)

Created:
3 years, 6 months ago by Lei Zhang
Modified:
3 years, 6 months ago
Reviewers:
msarett1
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Potentially do less work in PDFiumEngine::CreateSinglePageRasterPdf(). In r479694, the method started always doing some calculations even though the results will only be used under certain conditions. Review-Url: https://codereview.chromium.org/2947533002 Cr-Commit-Position: refs/heads/master@{#480539} Committed: https://chromium.googlesource.com/chromium/src/+/59c41df5c64b6bc8641412eb5c3b3d0681d9c8b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M pdf/pdfium/pdfium_engine.cc View 1 chunk +13 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Lei Zhang
3 years, 6 months ago (2017-06-17 03:04:34 UTC) #4
msarett1
lgtm
3 years, 6 months ago (2017-06-19 11:59:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2947533002/1
3 years, 6 months ago (2017-06-19 17:54:35 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-19 19:42:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/59c41df5c64b6bc8641412eb5c3b...

Powered by Google App Engine
This is Rietveld 408576698