Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: tools/testing/dart/browser_controller.dart

Issue 2947473002: Basic support for dev_compiler in test.dart. (Closed)
Patch Set: Merge branch 'master' into ddc-chrome-tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/browser_controller.dart
diff --git a/tools/testing/dart/browser_controller.dart b/tools/testing/dart/browser_controller.dart
index 50e14c15b7bfa889a97771d528b215edfa699f7d..3700a29aeb6814ea3252307f52b91ce5a7ff01f4 100644
--- a/tools/testing/dart/browser_controller.dart
+++ b/tools/testing/dart/browser_controller.dart
@@ -502,8 +502,13 @@ class Chrome extends Browser {
"--disable-extensions",
"--disable-popup-blocking",
"--bwsi",
- "--no-first-run"
+ "--no-first-run",
];
+
+ // TODO(rnystrom): Uncomment this to open the dev tools tab when Chrome
Bill Hesse 2017/06/21 16:33:20 Commented code is disallowed, I think. You could
Bob Nystrom 2017/06/21 20:18:28 Done.
+ // is spawned. Handy for debugging tests.
+ // args.add("--auto-open-devtools-for-tabs");
+
return startBrowserProcess(_binary, args,
environment: _getEnvironment());
});

Powered by Google App Engine
This is Rietveld 408576698