Prefer the exact match over prefix match for the password manager filling.

Prefer the exact match over prefix match for the password manager filling.

This CL addresses the following issue in username prefix matching:
In the rare case the user saved two credentials:
username / password1
username@example.com / password2
it may now happen that Chrome autofills password2 for username, creating
an incompatible mix.

We need to ensure that the exact match is always preferred.

BUG=543435

[melandory, 2017-06-22 14:02:17]

melandory@chromium.org changed reviewers:
+ vabr@chromium.org

[melandory, 2017-06-22 14:02:17]

PTAL, thanks!

[vabr (Chromium), 2017-06-22 14:25:28]

Thanks, Tanja, LGTM. Two comments, though:

(1) Please change the CL title (just the first line) to mention passwords and
filling. As it is, it is too generic and can confuse people reading a list of
commit titles.

(2) -- see the inline comment below.

Thanks!
Vaclav

https://codereview.chromium.org/2947403003/diff/1/chrome/renderer/autofill/pa...
File chrome/renderer/autofill/password_autofill_agent_browsertest.cc (right):

https://codereview.chromium.org/2947403003/diff/1/chrome/renderer/autofill/pa...
chrome/renderer/autofill/password_autofill_agent_browsertest.cc:775: // Filled
even though the username in the form is only a proper prefix of the
I'm not sure if the comment makes sense. There are many stored usernames, and
this test checks that the one used for filling was the one which matches
exactly, no?

[melandory, 2017-06-22 19:18:22]

Description was changed from

==========
Prefer the exact match over prefix match.

This CL addresses the following issue in username prefix matching:
In the rare case the user saved two credentials:
username / password1
username@example.com / password2
it may now happen that Chrome autofills password2 for username, creating
an incompatible mix.

We need to ensure that the exact match is always preferred.

BUG=543435
==========

to

==========
Prefer the exact match over prefix match for the password manager filling.

This CL addresses the following issue in username prefix matching:
In the rare case the user saved two credentials:
username / password1
username@example.com / password2
it may now happen that Chrome autofills password2 for username, creating
an incompatible mix.

We need to ensure that the exact match is always preferred.

BUG=543435
==========

[melandory, 2017-06-22 19:36:47]

The CQ bit was checked by melandory@chromium.org

[melandory, 2017-06-22 19:36:48]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/2947403003/#ps20001
(title: "Prefer the exact match over prefix match.")

[commit-bot: I haz the power, 2017-06-22 19:37:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 20:14:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 20:14:59]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vabr (Chromium), 2017-06-23 06:58:12]

https://codereview.chromium.org/2947403003/diff/20001/chrome/renderer/autofil...
File chrome/renderer/autofill/password_autofill_agent_browsertest.cc (right):

https://codereview.chromium.org/2947403003/diff/20001/chrome/renderer/autofil...
chrome/renderer/autofill/password_autofill_agent_browsertest.cc:776:
CheckTextFieldsState(UTF16ToUTF8(username2at_), false,
Yes, these two "false" should be "true" (we expect the fields to be marked as
autofilled). Sorry, I should have caught that yesterday.