Prefer the exact match over prefix match for the password manager filling.

chrome/renderer/autofill/password_autofill_agent_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_autofill_agent.h"
 
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
@@ skipping 50 matching lines @@
 const char kUsernameName[] = "username";
 const char kPasswordName[] = "password";
 const char kEmailName[] = "email";
 const char kCreditCardOwnerName[] = "creditcardowner";
 const char kCreditCardNumberName[] = "creditcardnumber";
 const char kCreditCardVerificationName[] = "cvc";
 
 const char kAliceUsername[] = "alice";
 const char kAlicePassword[] = "password";
 const char kBobUsername[] = "bob";
+const char kBobAtUsername[] = "bob@example.com";
 const char kBobPassword[] = "secret";
 const char kCarolUsername[] = "Carol";
 const char kCarolPassword[] = "test";
 const char kCarolAlternateUsername[] = "RealCarolUsername";
 
 const char kFormHTML[] =
     "<FORM id='LoginTestForm' action='http://www.bidule.com'>"
     "  <INPUT type='text' id='random_field'/>"
     "  <INPUT type='text' id='username'/>"
     "  <INPUT type='password' id='password'/>"
@@ skipping 195 matching lines @@
   }
 
   void SetUp() override {
     ChromeRenderViewTest::SetUp();
 
     // Add a preferred login and an additional login to the FillData.
     username1_ = ASCIIToUTF16(kAliceUsername);
     password1_ = ASCIIToUTF16(kAlicePassword);
     username2_ = ASCIIToUTF16(kBobUsername);
     password2_ = ASCIIToUTF16(kBobPassword);
+    username2at_ = ASCIIToUTF16(kBobAtUsername);
     username3_ = ASCIIToUTF16(kCarolUsername);
     password3_ = ASCIIToUTF16(kCarolPassword);
     alternate_username3_ = ASCIIToUTF16(kCarolAlternateUsername);
 
     FormFieldData username_field;
     username_field.name = ASCIIToUTF16(kUsernameName);
     username_field.value = username1_;
     fill_data_.username_field = username_field;
 
     FormFieldData password_field;
     password_field.name = ASCIIToUTF16(kPasswordName);
     password_field.value = password1_;
     password_field.form_control_type = "password";
     fill_data_.password_field = password_field;
 
     PasswordAndRealm password2;
     password2.password = password2_;
     fill_data_.additional_logins[username2_] = password2;
     PasswordAndRealm password3;
     password3.password = password3_;
     fill_data_.additional_logins[username3_] = password3;
+    fill_data_.additional_logins[username2at_] = password3;
 
     UsernamesCollectionKey key;
     key.username = username3_;
     key.password = password3_;
     key.realm = "google.com";
     fill_data_.other_possible_usernames[key].push_back(alternate_username3_);
 
     // We need to set the origin so it matches the frame URL and the action so
     // it matches the form action, otherwise we won't autocomplete.
     UpdateOriginForHTML(kFormHTML);
@@ skipping 295 matching lines @@
   void BindPasswordManagerClient(mojo::ScopedInterfaceEndpointHandle handle) {
     fake_pw_client_.BindRequest(
         mojom::PasswordManagerClientAssociatedRequest(std::move(handle)));
   }
 
   FakeContentPasswordManagerDriver fake_driver_;
   FakePasswordManagerClient fake_pw_client_;
 
   base::string16 username1_;
   base::string16 username2_;
+  base::string16 username2at_;
   base::string16 username3_;
   base::string16 password1_;
   base::string16 password2_;
   base::string16 password3_;
   base::string16 alternate_username3_;
   PasswordFormFillData fill_data_;
 
   WebInputElement username_element_;
   WebInputElement password_element_;
   base::test::ScopedFeatureList scoped_feature_list_;
@@ skipping 125 matching lines @@
       username3_ + base::UTF8ToUTF16("@example.com");
   username_element_.SetValue(WebString::FromUTF16(prefilled_username));
 
   // Filled even though the username in the form is only a proper prefix of the
   // stored username.
   SimulateOnFillPasswordForm(fill_data_);
   CheckTextFieldsState(UTF16ToUTF8(prefilled_username), false, std::string(),
                        false);
 }
 
+// Tests that the exact match is always preferred.
+TEST_F(PasswordAutofillAgentTest, TestThatExactMatchIsPreffered) {
+  username_element_.SetValue(WebString::FromUTF16(username2at_));
+
+  SimulateOnFillPasswordForm(fill_data_);
+  CheckTextFieldsState(UTF16ToUTF8(username2at_), false,

[vabr (Chromium), 2017/06/23 06:58:11]

Yes, these two "false" should be "true" (we expect the fields to be marked as
autofilled). Sorry, I should have caught that yesterday.

+                       UTF16ToUTF8(password3_), false);
+}
+
 // If a username field is empty and readonly, don't autofill.
 TEST_F(PasswordAutofillAgentTest,
        NoAutocompletePasswordForReadonlyUsernameUnmatched) {
   username_element_.SetValue(WebString::FromUTF8(""));
   SetElementReadOnly(username_element_, true);
 
   SimulateOnFillPasswordForm(fill_data_);
   CheckTextFieldsState(std::string(), false, std::string(), false);
 }
 
@@ skipping 2245 matching lines @@
   // Repeatedly occurring AJAX events without removing the input elements
   // shouldn't be treated as a password submission.
   password_autofill_agent_->AJAXSucceeded();
   base::RunLoop().RunUntilIdle();
 
   ASSERT_FALSE(fake_driver_.called_password_form_submitted());
   ASSERT_FALSE(static_cast<bool>(fake_driver_.password_form_submitted()));
 }
 
 }  // namespace autofill