build/config/mac/compile_ib_files.py - Issue 2947393002: compile_ib_files.py: Wait for subprocess.Popen() to finish.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/mac/compile_ib_files.py

Issue 2947393002: compile_ib_files.py: Wait for subprocess.Popen() to finish. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/mac/compile_ib_files.py

diff --git a/build/config/mac/compile_ib_files.py b/build/config/mac/compile_ib_files.py

index 4923d82984cefadb4d2c4e1c579b73a8175c416f..6d78f39c157c3bbadf20bbdb32a9083f21e3b7d9 100644

--- a/build/config/mac/compile_ib_files.py

+++ b/build/config/mac/compile_ib_files.py

@@ -41,6 +41,7 @@ def main():

ibtool_section_re = re.compile(r'/\*.*\*/')

ibtool_re = re.compile(r'.*note:.*is clipping its content')

ibtoolout = subprocess.Popen(ibtool_args, stdout=subprocess.PIPE)

Robert Sesek 2017/06/22 15:13:04 Any reason to not use subprocess.check_output?

+ ibtoolout.wait()

current_section_header = None

for line in ibtoolout.stdout:

if ibtool_section_re.match(line):

« no previous file with comments | « no previous file | no next file » | no next file with comments »