compile_ib_files.py: Wait for subprocess.Popen() to finish.

build/config/mac/compile_ib_files.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 
 import argparse
 import logging
 import os
 import re
 import subprocess
@@ skipping 22 matching lines @@
   ]
   ibtool_args += unknown_args
   ibtool_args += [
       '--compile',
       os.path.abspath(args.output),
       os.path.abspath(args.input)
   ]
 
   ibtool_section_re = re.compile(r'/\*.*\*/')
   ibtool_re = re.compile(r'.*note:.*is clipping its content')
   ibtoolout = subprocess.Popen(ibtool_args, stdout=subprocess.PIPE)

[Robert Sesek, 2017/06/22 15:13:04]

Any reason to not use subprocess.check_output?

+  ibtoolout.wait()
   current_section_header = None
   for line in ibtoolout.stdout:
     if ibtool_section_re.match(line):
       current_section_header = line
     elif not ibtool_re.match(line):
       if current_section_header:
         sys.stdout.write(current_section_header)
         current_section_header = None
       sys.stdout.write(line)
   return ibtoolout.returncode
 
 
 if __name__ == '__main__':
   sys.exit(main())