Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2947303003: Remove Redundant common ash_unittests from mash_unittests (Closed)

Created:
3 years, 6 months ago by jonross
Modified:
3 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Redundant common ash_unittests from mash_unittests We can now run the mash version of ash_unittests via ash_unittests --mash The mash_unittests target brings in a redundant set of tests via ash:common_unittets. This change removes that import. There are still some ash/mus specific tests in this test suite, however they rely on additional setup work which is not yet available in ash_unittests --mash TEST=mash_unittests BUG=729810 Review-Url: https://codereview.chromium.org/2947303003 Cr-Commit-Position: refs/heads/master@{#481613} Committed: https://chromium.googlesource.com/chromium/src/+/452f0fd1a8564e39ca732c1818083ec53959aa6f

Patch Set 1 #

Patch Set 2 : Fix includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mash/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
jonross
Hey sky@, As a part of removing mash_unittests I found that the tests specifically written ...
3 years, 6 months ago (2017-06-22 14:50:52 UTC) #2
sky
LGTM
3 years, 6 months ago (2017-06-22 15:31:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2947303003/20001
3 years, 6 months ago (2017-06-22 16:07:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/485565)
3 years, 6 months ago (2017-06-22 17:13:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2947303003/20001
3 years, 6 months ago (2017-06-22 17:45:50 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 18:46:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/452f0fd1a8564e39ca732c181808...

Powered by Google App Engine
This is Rietveld 408576698