Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2947293002: [Android] Ensure omnibox suggestions reappear after refocusing Chrome. (Closed)

Created:
3 years, 6 months ago by Ted C
Modified:
3 years, 6 months ago
Reviewers:
Maria
CC:
chromium-reviews, jdonnelly+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Ensure omnibox suggestions reappear after refocusing Chrome. When losing window focus, the omnibox suggestions are removed and when bringing back focus to Chrome they are not redisplayed. We should retrigger the omnibox suggestions when bringing Chrome back to the foreground when the url bar retains focus. BUG= Review-Url: https://codereview.chromium.org/2947293002 Cr-Commit-Position: refs/heads/master@{#481398} Committed: https://chromium.googlesource.com/chromium/src/+/6c0f2e43f118820b4ce2cc047caf13a9a0c0771d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java View 2 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Ted C
PTAL
3 years, 6 months ago (2017-06-21 23:45:25 UTC) #2
Maria
lgtm
3 years, 6 months ago (2017-06-21 23:59:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2947293002/1
3 years, 6 months ago (2017-06-22 00:08:38 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 01:51:42 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6c0f2e43f118820b4ce2cc047caf...

Powered by Google App Engine
This is Rietveld 408576698