Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2895)

Unified Diff: chrome/browser/ui/app_list/search/answer_card/answer_card_search_provider.h

Issue 2947283002: Unit-testing AnswerCardSearchProvider. (Closed)
Patch Set: CR comments Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/search/answer_card/answer_card_search_provider.h
diff --git a/chrome/browser/ui/app_list/search/answer_card/answer_card_search_provider.h b/chrome/browser/ui/app_list/search/answer_card/answer_card_search_provider.h
index dc776a6be15e29797c20f526ba25f7265dfb2a33..75b538e9c49baad8057ef1c3be5627d8de3fbd06 100644
--- a/chrome/browser/ui/app_list/search/answer_card/answer_card_search_provider.h
+++ b/chrome/browser/ui/app_list/search/answer_card/answer_card_search_provider.h
@@ -22,10 +22,6 @@ namespace app_list {
class AppListModel;
}
-namespace net {
-class HttpResponseHeaders;
-}
-
namespace app_list {
// Search provider for the answer card.
@@ -45,17 +41,17 @@ class AnswerCardSearchProvider : public SearchProvider,
// AnswerCardContents::Delegate overrides:
void UpdatePreferredSize(const gfx::Size& pref_size) override;
- content::WebContents* OpenURLFromTab(
- const content::OpenURLParams& params) override;
- void DidFinishNavigation(
- content::NavigationHandle* navigation_handle) override;
+ void DidFinishNavigation(const GURL& url,
+ bool has_error,
+ bool has_answer_card,
+ const std::string& result_title,
+ const std::string& issued_query) override;
void DidStopLoading() override;
private:
bool IsCardSizeOk() const;
void RecordReceivedAnswerFinalResult();
void OnResultAvailable(bool is_available);
- bool ParseResponseHeaders(const net::HttpResponseHeaders* headers);
// Returns Url to open when the user clicks at the result for |query|.
std::string GetResultUrl(const base::string16& query) const;

Powered by Google App Engine
This is Rietveld 408576698