Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: chrome/browser/ui/app_list/search/answer_card/answer_card_contents.h

Issue 2947283002: Unit-testing AnswerCardSearchProvider. (Closed)
Patch Set: CR comments Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/app_list/search/answer_card/answer_card_search_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/app_list/search/answer_card/answer_card_contents.h
diff --git a/chrome/browser/ui/app_list/search/answer_card/answer_card_contents.h b/chrome/browser/ui/app_list/search/answer_card/answer_card_contents.h
index 87ec12ae4027dd95a9a0545966547fe249b697c8..2e855a5475e8e04e47ef2622f905aa9c032b7f4d 100644
--- a/chrome/browser/ui/app_list/search/answer_card/answer_card_contents.h
+++ b/chrome/browser/ui/app_list/search/answer_card/answer_card_contents.h
@@ -13,12 +13,6 @@ namespace app_list {
class AnswerCardResult;
}
-namespace content {
-class NavigationHandle;
-struct OpenURLParams;
-class WebContents;
-}
-
namespace gfx {
class Size;
}
@@ -41,10 +35,11 @@ class AnswerCardContents {
// events in WebContentsDelegate and WebContentsObserver, however,
// unnecessary parameters are omitted.
virtual void UpdatePreferredSize(const gfx::Size& pref_size) = 0;
- virtual content::WebContents* OpenURLFromTab(
- const content::OpenURLParams& params) = 0;
- virtual void DidFinishNavigation(
- content::NavigationHandle* navigation_handle) = 0;
+ virtual void DidFinishNavigation(const GURL& url,
+ bool has_error,
+ bool has_answer_card,
+ const std::string& result_title,
+ const std::string& issued_query) = 0;
virtual void DidStopLoading() = 0;
private:
« no previous file with comments | « no previous file | chrome/browser/ui/app_list/search/answer_card/answer_card_search_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698