Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2947193002: Polymer: Remove unused paper-dropdown-menu, paper-menu-button. (Closed)

Created:
3 years, 6 months ago by dpapad
Modified:
3 years, 6 months ago
Reviewers:
scottchen, michaelpg
CC:
chromium-reviews, dcheng, michaelpg+watch-polymer_chromium.org, michaelpg, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Polymer: Remove unused paper-dropdown-menu, paper-menu-button. Also update reproduce.sh script to pass the --production flag to bower, otherwise devDependencies are also pulled in. BUG=735585 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2947193002 Cr-Commit-Position: refs/heads/master@{#481969} Committed: https://chromium.googlesource.com/chromium/src/+/4da73c092149777b32b73e9b324d907ae2bc990e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1823 lines) Patch
M third_party/polymer/v1_0/bower.json View 2 chunks +0 lines, -2 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/bower.json View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/compiled_resources2.gyp View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu.html View 1 chunk +0 lines, -100 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu-extracted.js View 1 chunk +0 lines, -281 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu-icons.html View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu-light.html View 1 chunk +0 lines, -290 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu-light-extracted.js View 1 chunk +0 lines, -292 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu-shared-styles.html View 1 chunk +0 lines, -78 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-menu-button/bower.json View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-menu-button/compiled_resources2.gyp View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-menu-button/paper-menu-button.html View 1 chunk +0 lines, -123 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-menu-button/paper-menu-button-animations.html View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-menu-button/paper-menu-button-animations-extracted.js View 1 chunk +0 lines, -92 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-menu-button/paper-menu-button-extracted.js View 1 chunk +0 lines, -338 lines 0 comments Download
M third_party/polymer/v1_0/components_summary.txt View 2 chunks +0 lines, -12 lines 0 comments Download
M third_party/polymer/v1_0/reproduce.sh View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/polymer_resources.grdp View 2 chunks +0 lines, -24 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
dpapad
3 years, 6 months ago (2017-06-21 20:37:18 UTC) #6
dpapad
Redirecting to scottchen@ since michaelpg@ is not available (per their calendar).
3 years, 6 months ago (2017-06-21 21:02:36 UTC) #8
dpapad
On 2017/06/21 at 21:02:36, dpapad wrote: > Redirecting to scottchen@ since michaelpg@ is not available ...
3 years, 6 months ago (2017-06-23 01:29:09 UTC) #12
michaelpg
lgtm
3 years, 6 months ago (2017-06-23 17:11:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2947193002/1
3 years, 6 months ago (2017-06-23 17:20:34 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 18:45:37 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4da73c092149777b32b73e9b324d...

Powered by Google App Engine
This is Rietveld 408576698