Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2947023002: Clean up ifdefs in base stack sampling profiler unit test. (Closed)

Created:
3 years, 6 months ago by Alexei Svitkine (slow)
Modified:
3 years, 6 months ago
Reviewers:
Mike Wittman
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up ifdefs in base stack sampling profiler unit test. This keeps the property of compiling the code on all platforms, while removing the need to have a ton of individual per-test ifdefs. For tests that are later disabled for other reasons, this can result in DISABLED_ prefix appearing two times, but that doesn't seem too problematic and the code cleanup benefits outweigh that. BUG=none Review-Url: https://codereview.chromium.org/2947023002 Cr-Commit-Position: refs/heads/master@{#480949} Committed: https://chromium.googlesource.com/chromium/src/+/a933334960a47bbb9dab17f17f1341c80ed4749d

Patch Set 1 #

Patch Set 2 : missed some TEST_F's #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -141 lines) Patch
M base/profiler/stack_sampling_profiler_unittest.cc View 1 24 chunks +39 lines, -141 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
Alexei Svitkine (slow)
Still working on getting my other CL for periodic sampling cleaned up for review, but ...
3 years, 6 months ago (2017-06-20 19:47:53 UTC) #5
Mike Wittman
lgtm, thanks!
3 years, 6 months ago (2017-06-20 20:28:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2947023002/40001
3 years, 6 months ago (2017-06-20 20:38:58 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 20:47:05 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a933334960a47bbb9dab17f17f13...

Powered by Google App Engine
This is Rietveld 408576698