Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: chrome/common/BUILD.gn

Issue 2946983002: Move eventlog_provider from //base/win to //chrome/common/win (Closed)
Patch Set: Add dep to chrome:common Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/BUILD.gn
diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn
index e975e3e0f8f3d243296a4b7c0fab380f9adba013..d3284635bea291ec7145dffe3cfbd4c22db88802 100644
--- a/chrome/common/BUILD.gn
+++ b/chrome/common/BUILD.gn
@@ -179,6 +179,7 @@ static_library("common") {
"//chrome/common/media_router/mojo:dial_utility_interfaces",
"//chrome/common/net",
"//chrome/common/safe_browsing:proto",
+ "//chrome/common/win:eventlog_messages",
grt (UTC plus 2) 2017/06/21 20:26:15 i *think* this can be in deps rather than public_d
proberge 2017/06/21 21:33:39 Moved to an is_win block. There's no non-public d
grt (UTC plus 2) 2017/06/21 21:48:01 i don't see why not. i think minimal visibility is
proberge 2017/06/22 14:35:47 Done.
"//chrome/installer/util:with_no_strings",
"//components/autofill/content/common:ipc_traits",
"//components/autofill/core/common",

Powered by Google App Engine
This is Rietveld 408576698