Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: chrome/common/BUILD.gn

Issue 2946983002: Move eventlog_provider from //base/win to //chrome/common/win (Closed)
Patch Set: Add dep to chrome:common Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/util/process_version.gni") 6 import("//build/util/process_version.gni")
7 import("//chrome/common/features.gni") 7 import("//chrome/common/features.gni")
8 import("//chrome/process_version_rc_template.gni") # For branding_file_path. 8 import("//chrome/process_version_rc_template.gni") # For branding_file_path.
9 import("//extensions/features/features.gni") 9 import("//extensions/features/features.gni")
10 import("//mojo/public/tools/bindings/mojom.gni") 10 import("//mojo/public/tools/bindings/mojom.gni")
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 "//base:base", 172 "//base:base",
173 "//base:base_static", 173 "//base:base_static",
174 "//base:i18n", 174 "//base:i18n",
175 "//chrome:resources", 175 "//chrome:resources",
176 "//chrome:strings", 176 "//chrome:strings",
177 "//chrome/app/theme:theme_resources", 177 "//chrome/app/theme:theme_resources",
178 "//chrome/common:constants", 178 "//chrome/common:constants",
179 "//chrome/common/media_router/mojo:dial_utility_interfaces", 179 "//chrome/common/media_router/mojo:dial_utility_interfaces",
180 "//chrome/common/net", 180 "//chrome/common/net",
181 "//chrome/common/safe_browsing:proto", 181 "//chrome/common/safe_browsing:proto",
182 "//chrome/common/win:eventlog_messages",
grt (UTC plus 2) 2017/06/21 20:26:15 i *think* this can be in deps rather than public_d
proberge 2017/06/21 21:33:39 Moved to an is_win block. There's no non-public d
grt (UTC plus 2) 2017/06/21 21:48:01 i don't see why not. i think minimal visibility is
proberge 2017/06/22 14:35:47 Done.
182 "//chrome/installer/util:with_no_strings", 183 "//chrome/installer/util:with_no_strings",
183 "//components/autofill/content/common:ipc_traits", 184 "//components/autofill/content/common:ipc_traits",
184 "//components/autofill/core/common", 185 "//components/autofill/core/common",
185 "//components/cast_certificate", 186 "//components/cast_certificate",
186 "//components/cdm/common", 187 "//components/cdm/common",
187 "//components/cloud_devices/common", 188 "//components/cloud_devices/common",
188 "//components/component_updater", 189 "//components/component_updater",
189 "//components/content_settings/core/common", 190 "//components/content_settings/core/common",
190 "//components/crash/core/common", 191 "//components/crash/core/common",
191 "//components/dom_distiller/core", 192 "//components/dom_distiller/core",
(...skipping 578 matching lines...) Expand 10 before | Expand all | Expand 10 after
770 771
771 mojom("page_load_metrics_mojom") { 772 mojom("page_load_metrics_mojom") {
772 sources = [ 773 sources = [
773 "page_load_metrics/page_load_metrics.mojom", 774 "page_load_metrics/page_load_metrics.mojom",
774 ] 775 ]
775 776
776 public_deps = [ 777 public_deps = [
777 "//mojo/common:common_custom_types", 778 "//mojo/common:common_custom_types",
778 ] 779 ]
779 } 780 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698