Prepare DownloadRequestLimiterTest for enabling PermissionRequestManager on Android

Prepare DownloadRequestLimiterTest for enabling PermissionRequestManager on Android

This patch updates the DownloadRequestLimiterTest so that we'll be able
to enable the PermissionRequestManager on Android without needing to
change this test at the same time.

Currently the tests use a testing delegate, which on Android calls into
the infobar system and on desktop calls into the PRM. Instead of making
the TestingDelegate implement an interface, we just remove the delegate
and inline the logic into the test fixture. This is as we plan to remove
the infobar paths once the PRM is shipped, after which we won't need the
complexity of a delegate.

This patch also updates DownloadRequestLimiter_RawWebContents so that
it runs on desktop as well as Android.

BUG=606138
Review-Url: https://codereview.chromium.org/2946953003
Cr-Commit-Position: refs/heads/master@{#481149}
Committed: https://chromium.googlesource.com/chromium/src/+/7ef4fb730f1d56441a16be8e47f0d4da582c0be2

[Timothy Loh, 2017-06-21 05:00:04]

The CQ bit was checked by timloh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 05:00:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Timothy Loh, 2017-06-21 05:16:39]

Description was changed from

==========
Prepare DownloadRequestLimiterTest for enabling PermissionRequestManager on
Android

BUG=606138
==========

to

==========
Prepare DownloadRequestLimiterTest for enabling PermissionRequestManager on
Android

This patch updates the DownloadRequestLimiterTest so that we'll be able
to enable the PermissionRequestManager on Android without needing to
change it at the same time.

Currently the tests use a testing delegate, which on Android calls into
the infobar system and on desktop calls into the PRM. Instead of making
the TestingDelegate implement an interface, we just remove the delegate
and inline the logic into the test fixture. This is as we plan to remove
the infobar paths once the PRM is shipped, after which we won't need the
complexity of a delegate.

This patch also updates DownloadRequestLimiter_RawWebContents so that
it runs on desktop as well as Android.

BUG=606138
==========

[commit-bot: I haz the power, 2017-06-21 06:04:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 06:04:57]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Timothy Loh, 2017-06-21 06:33:55]

The CQ bit was checked by timloh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 06:34:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Timothy Loh, 2017-06-21 06:41:10]

Description was changed from

==========
Prepare DownloadRequestLimiterTest for enabling PermissionRequestManager on
Android

This patch updates the DownloadRequestLimiterTest so that we'll be able
to enable the PermissionRequestManager on Android without needing to
change it at the same time.

Currently the tests use a testing delegate, which on Android calls into
the infobar system and on desktop calls into the PRM. Instead of making
the TestingDelegate implement an interface, we just remove the delegate
and inline the logic into the test fixture. This is as we plan to remove
the infobar paths once the PRM is shipped, after which we won't need the
complexity of a delegate.

This patch also updates DownloadRequestLimiter_RawWebContents so that
it runs on desktop as well as Android.

BUG=606138
==========

to

==========
Prepare DownloadRequestLimiterTest for enabling PermissionRequestManager on
Android

This patch updates the DownloadRequestLimiterTest so that we'll be able
to enable the PermissionRequestManager on Android without needing to
change this test at the same time.

Currently the tests use a testing delegate, which on Android calls into
the infobar system and on desktop calls into the PRM. Instead of making
the TestingDelegate implement an interface, we just remove the delegate
and inline the logic into the test fixture. This is as we plan to remove
the infobar paths once the PRM is shipped, after which we won't need the
complexity of a delegate.

This patch also updates DownloadRequestLimiter_RawWebContents so that
it runs on desktop as well as Android.

BUG=606138
==========

[Timothy Loh, 2017-06-21 06:41:36]

timloh@chromium.org changed reviewers:
+ dominickn@chromium.org

[dominickn, 2017-06-21 07:13:26]

lgtm

[Timothy Loh, 2017-06-21 07:21:11]

The CQ bit was unchecked by timloh@chromium.org

[Timothy Loh, 2017-06-21 07:21:11]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2017-06-21 07:21:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 08:52:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498029671867040,
"parent_rev": "133f0fbf24875e109392c64c0108385ca4c32f52", "commit_rev":
"7ef4fb730f1d56441a16be8e47f0d4da582c0be2"}

[commit-bot: I haz the power, 2017-06-21 08:52:19]

Description was changed from

==========
Prepare DownloadRequestLimiterTest for enabling PermissionRequestManager on
Android

This patch updates the DownloadRequestLimiterTest so that we'll be able
to enable the PermissionRequestManager on Android without needing to
change this test at the same time.

Currently the tests use a testing delegate, which on Android calls into
the infobar system and on desktop calls into the PRM. Instead of making
the TestingDelegate implement an interface, we just remove the delegate
and inline the logic into the test fixture. This is as we plan to remove
the infobar paths once the PRM is shipped, after which we won't need the
complexity of a delegate.

This patch also updates DownloadRequestLimiter_RawWebContents so that
it runs on desktop as well as Android.

BUG=606138
==========

to

==========
Prepare DownloadRequestLimiterTest for enabling PermissionRequestManager on
Android

This patch updates the DownloadRequestLimiterTest so that we'll be able
to enable the PermissionRequestManager on Android without needing to
change this test at the same time.

Currently the tests use a testing delegate, which on Android calls into
the infobar system and on desktop calls into the PRM. Instead of making
the TestingDelegate implement an interface, we just remove the delegate
and inline the logic into the test fixture. This is as we plan to remove
the infobar paths once the PRM is shipped, after which we won't need the
complexity of a delegate.

This patch also updates DownloadRequestLimiter_RawWebContents so that
it runs on desktop as well as Android.

BUG=606138

Review-Url: https://codereview.chromium.org/2946953003
Cr-Commit-Position: refs/heads/master@{#481149}
Committed:
https://chromium.googlesource.com/chromium/src/+/7ef4fb730f1d56441a16be8e47f0...
==========

[commit-bot: I haz the power, 2017-06-21 08:52:20]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7ef4fb730f1d56441a16be8e47f0...