Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: src/compiler/verifier.cc

Issue 2946893004: [WIP] Start adding JSCallWithVarargs
Patch Set: REBASE Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/verifier.cc
diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc
index 92ac30d7e6607e45810eb8d4facc58f390d7ce5d..22ed14d5854572ed81934d9bf14ea114f253f6f4 100644
--- a/src/compiler/verifier.cc
+++ b/src/compiler/verifier.cc
@@ -720,8 +720,16 @@ void Verifier::Visitor::Check(Node* node) {
// Type is Receiver.
CheckTypeIs(node, Type::Receiver());
break;
- case IrOpcode::kJSCallForwardVarargs:
+ case IrOpcode::kJSCallVarargs: {
+ int arity = static_cast<int>(CallVarargsParametersOf(node->op()).arity());
+ CheckValueInputIs(node, arity + 0, Type::OtherInternal());
+ CheckValueInputIs(node, arity + 1, Type::Signed32());
+ // Type can be any JavaScript value.
+ CheckTypeIs(node, Type::NonInternal());
+ break;
+ }
case IrOpcode::kJSCall:
+ case IrOpcode::kJSCallForwardVarargs:
case IrOpcode::kJSCallWithArrayLike:
case IrOpcode::kJSCallWithSpread:
case IrOpcode::kJSCallRuntime:
« no previous file with comments | « src/compiler/typer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698