Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Side by Side Diff: src/compiler/verifier.cc

Issue 2946893004: [WIP] Start adding JSCallWithVarargs
Patch Set: REBASE Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 702 matching lines...) Expand 10 before | Expand all | Expand 10 after
713 } 713 }
714 714
715 case IrOpcode::kJSConstructForwardVarargs: 715 case IrOpcode::kJSConstructForwardVarargs:
716 case IrOpcode::kJSConstruct: 716 case IrOpcode::kJSConstruct:
717 case IrOpcode::kJSConstructWithArrayLike: 717 case IrOpcode::kJSConstructWithArrayLike:
718 case IrOpcode::kJSConstructWithSpread: 718 case IrOpcode::kJSConstructWithSpread:
719 case IrOpcode::kJSConvertReceiver: 719 case IrOpcode::kJSConvertReceiver:
720 // Type is Receiver. 720 // Type is Receiver.
721 CheckTypeIs(node, Type::Receiver()); 721 CheckTypeIs(node, Type::Receiver());
722 break; 722 break;
723 case IrOpcode::kJSCallVarargs: {
724 int arity = static_cast<int>(CallVarargsParametersOf(node->op()).arity());
725 CheckValueInputIs(node, arity + 0, Type::OtherInternal());
726 CheckValueInputIs(node, arity + 1, Type::Signed32());
727 // Type can be any JavaScript value.
728 CheckTypeIs(node, Type::NonInternal());
729 break;
730 }
731 case IrOpcode::kJSCall:
723 case IrOpcode::kJSCallForwardVarargs: 732 case IrOpcode::kJSCallForwardVarargs:
724 case IrOpcode::kJSCall:
725 case IrOpcode::kJSCallWithArrayLike: 733 case IrOpcode::kJSCallWithArrayLike:
726 case IrOpcode::kJSCallWithSpread: 734 case IrOpcode::kJSCallWithSpread:
727 case IrOpcode::kJSCallRuntime: 735 case IrOpcode::kJSCallRuntime:
728 // Type can be anything. 736 // Type can be anything.
729 CheckTypeIs(node, Type::Any()); 737 CheckTypeIs(node, Type::Any());
730 break; 738 break;
731 739
732 case IrOpcode::kJSForInPrepare: { 740 case IrOpcode::kJSForInPrepare: {
733 // TODO(bmeurer): What are the constraints on thse? 741 // TODO(bmeurer): What are the constraints on thse?
734 CheckTypeIs(node, Type::Any()); 742 CheckTypeIs(node, Type::Any());
(...skipping 1057 matching lines...) Expand 10 before | Expand all | Expand 10 after
1792 replacement->op()->EffectOutputCount() > 0); 1800 replacement->op()->EffectOutputCount() > 0);
1793 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1801 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1794 replacement->opcode() == IrOpcode::kFrameState); 1802 replacement->opcode() == IrOpcode::kFrameState);
1795 } 1803 }
1796 1804
1797 #endif // DEBUG 1805 #endif // DEBUG
1798 1806
1799 } // namespace compiler 1807 } // namespace compiler
1800 } // namespace internal 1808 } // namespace internal
1801 } // namespace v8 1809 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698