MD Bookmarks: Deselect items when they are moved to a new folder

MD Bookmarks: Deselect items when they are moved to a new folder

This fixes an issue where the multi-select toolbar would still appear
after the selected items had been moved to a different folder.

BUG=697706
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2946883002
Cr-Commit-Position: refs/heads/master@{#481749}
Committed: https://chromium.googlesource.com/chromium/src/+/bdcfd1d3fd877ff71ae43f45a73daa3e773b130f

[tsergeant, 2017-06-20 07:39:01]

Description was changed from

==========
MD Bookmarks: Deselect items when they are moved to a new folder

This fixes an issue where the multi-select toolbar would still appear
after the selected items had been moved to a different folder.

BUG=697706
==========

to

==========
MD Bookmarks: Deselect items when they are moved to a new folder

This fixes an issue where the multi-select toolbar would still appear
after the selected items had been moved to a different folder.

BUG=697706
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-06-20 07:42:29]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 07:42:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2017-06-20 07:43:54]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[tsergeant, 2017-06-20 07:44:00]

PTAL

[commit-bot: I haz the power, 2017-06-20 09:23:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 09:23:22]

Dry run: This issue passed the CQ dry run.

[calamity, 2017-06-22 05:35:34]

lgtm

https://codereview.chromium.org/2946883002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_bookmarks/reducers_test.js (right):

https://codereview.chromium.org/2946883002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/reducers_test.js:141: action =
bookmarks.actions.moveBookmark('2', '1', 0, '0', 1);
I feel like we should have made these objects. It's pretty hard to read the args
as is =\

[tsergeant, 2017-06-22 06:59:09]

https://codereview.chromium.org/2946883002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_bookmarks/reducers_test.js (right):

https://codereview.chromium.org/2946883002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/reducers_test.js:141: action =
bookmarks.actions.moveBookmark('2', '1', 0, '0', 1);
On 2017/06/22 05:35:34, calamity wrote:
> I feel like we should have made these objects. It's pretty hard to read the
args
> as is =\

Do you mean in general or just in this test?

This is kind of the worst case that we have. We could change this test to
directly construct the object, but I don't think it's bad enough to warrant it.

[tsergeant, 2017-06-22 06:59:17]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2017-06-22 06:59:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[calamity, 2017-06-22 07:06:54]

On 2017/06/22 06:59:09, tsergeant wrote:
>
https://codereview.chromium.org/2946883002/diff/20001/chrome/test/data/webui/...
> File chrome/test/data/webui/md_bookmarks/reducers_test.js (right):
> 
>
https://codereview.chromium.org/2946883002/diff/20001/chrome/test/data/webui/...
> chrome/test/data/webui/md_bookmarks/reducers_test.js:141: action =
> bookmarks.actions.moveBookmark('2', '1', 0, '0', 1);
> On 2017/06/22 05:35:34, calamity wrote:
> > I feel like we should have made these objects. It's pretty hard to read the
> args
> > as is =\
> 
> Do you mean in general or just in this test?
> 
> This is kind of the worst case that we have. We could change this test to
> directly construct the object, but I don't think it's bad enough to warrant
it.

In general. removeBookmark isn't terribly readable either. Perhaps just
something to keep in mind if we ever add more actions.

[commit-bot: I haz the power, 2017-06-22 07:54:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 07:54:06]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tsergeant, 2017-06-22 23:13:46]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2017-06-22 23:14:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 00:47:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498173226542290,
"parent_rev": "2be84dd0d41f8247d22bdc8690b5520d6c483a8d", "commit_rev":
"bdcfd1d3fd877ff71ae43f45a73daa3e773b130f"}

[commit-bot: I haz the power, 2017-06-23 00:47:55]

Description was changed from

==========
MD Bookmarks: Deselect items when they are moved to a new folder

This fixes an issue where the multi-select toolbar would still appear
after the selected items had been moved to a different folder.

BUG=697706
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Bookmarks: Deselect items when they are moved to a new folder

This fixes an issue where the multi-select toolbar would still appear
after the selected items had been moved to a different folder.

BUG=697706
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2946883002
Cr-Commit-Position: refs/heads/master@{#481749}
Committed:
https://chromium.googlesource.com/chromium/src/+/bdcfd1d3fd877ff71ae43f45a73d...
==========

[commit-bot: I haz the power, 2017-06-23 00:47:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bdcfd1d3fd877ff71ae43f45a73d...