Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2946833003:
Update list of Feature Policy features (Closed)
DescriptionUpdate list of Feature Policy features
This makes 2 changes to the list of FP features:
1) Move microphone, camera, speaker encrypted-media, midi and geolocation out of
"experimental" features so that they will be succesfully parsed in the allow
attribute, even though they are not used yet.
2) Remove push, notifications and webrtc which are remnants from outdated
efforts/thinking.
BUG=689802
Review-Url: https://codereview.chromium.org/2946833003
Cr-Commit-Position: refs/heads/master@{#484039}
Committed: https://chromium.googlesource.com/chromium/src/+/ba6175053f21d892273483c16b8e09b7d4b70fb3
Patch Set 1 #Patch Set 2 : Update list of Feature Policy features #
Total comments: 2
Patch Set 3 : Update list of Feature Policy features #
Messages
Total messages: 26 (13 generated)
raymes@chromium.org changed reviewers: + iclelland@chromium.org
Hey Ian - I'm thinking we want to ensure that developers can add these things without getting a syntax error, even though the features do nothing yet. This will mean that developers can modify their code (without error) before we actually ship the changes to the platform. I'm following this up with the deprecation warning message. Does that seem reasonable?
On 2017/06/20 05:22:05, raymes wrote: > Hey Ian - I'm thinking we want to ensure that developers can add these things > without getting a syntax error, even though the features do nothing yet. This > will mean that developers can modify their code (without error) before we > actually ship the changes to the platform. I'm following this up with the > deprecation warning message. > > Does that seem reasonable? Friendly ping :)
Hi raymes, for your interest, Ian is on vacation right now On Jun 21, 2017 17:35, <raymes@chromium.org> wrote: > On 2017/06/20 05:22:05, raymes wrote: > > Hey Ian - I'm thinking we want to ensure that developers can add these > things > > without getting a syntax error, even though the features do nothing yet. > This > > will mean that developers can modify their code (without error) before we > > actually ship the changes to the platform. I'm following this up with the > > deprecation warning message. > > > > Does that seem reasonable? > > Friendly ping :) > > https://codereview.chromium.org/2946833003/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Hi raymes, for your interest, Ian is on vacation right now On Jun 21, 2017 17:35, <raymes@chromium.org> wrote: > On 2017/06/20 05:22:05, raymes wrote: > > Hey Ian - I'm thinking we want to ensure that developers can add these > things > > without getting a syntax error, even though the features do nothing yet. > This > > will mean that developers can modify their code (without error) before we > > actually ship the changes to the platform. I'm following this up with the > > deprecation warning message. > > > > Does that seem reasonable? > > Friendly ping :) > > https://codereview.chromium.org/2946833003/ > -- You received this message because you are subscribed to the Google Groups "Blink Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-reviews+unsubscribe@chromium.org.
Sorry for the lag there -- this LGTM, thanks for keeping it up to date! https://codereview.chromium.org/2946833003/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp (right): https://codereview.chromium.org/2946833003/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp:122: nit: remove blank line
raymes@chromium.org changed reviewers: + pfeldman@chromium.org
+pfeldman for OWNERS https://codereview.chromium.org/2946833003/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp (right): https://codereview.chromium.org/2946833003/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp:122: On 2017/06/22 13:06:09, iclelland wrote: > nit: remove blank line Done.
The CQ bit was checked by raymes@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/06/26 05:59:05, raymes wrote: > +pfeldman for OWNERS > > https://codereview.chromium.org/2946833003/diff/20001/third_party/WebKit/Sour... > File third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp > (right): > > https://codereview.chromium.org/2946833003/diff/20001/third_party/WebKit/Sour... > third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp:122: > On 2017/06/22 13:06:09, iclelland wrote: > > nit: remove blank line > > Done. pfeldman@: ping :)
raymes@chromium.org changed reviewers: + kinuko@chromium.org - pfeldman@chromium.org
+kinuko for OWNERS (looks like pfeldman is away)
lgtm, sorry for the delay!
The CQ bit was checked by raymes@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from iclelland@chromium.org Link to the patchset: https://codereview.chromium.org/2946833003/#ps40001 (title: "Update list of Feature Policy features")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by raymes@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499128598246690,
"parent_rev": "acc56f7ade646212b19d55ea4fc9a4d7e5bc935d", "commit_rev":
"ba6175053f21d892273483c16b8e09b7d4b70fb3"}
Message was sent while issue was closed.
Description was changed from ========== Update list of Feature Policy features This makes 2 changes to the list of FP features: 1) Move microphone, camera, speaker encrypted-media, midi and geolocation out of "experimental" features so that they will be succesfully parsed in the allow attribute, even though they are not used yet. 2) Remove push, notifications and webrtc which are remnants from outdated efforts/thinking. BUG=689802 ========== to ========== Update list of Feature Policy features This makes 2 changes to the list of FP features: 1) Move microphone, camera, speaker encrypted-media, midi and geolocation out of "experimental" features so that they will be succesfully parsed in the allow attribute, even though they are not used yet. 2) Remove push, notifications and webrtc which are remnants from outdated efforts/thinking. BUG=689802 Review-Url: https://codereview.chromium.org/2946833003 Cr-Commit-Position: refs/heads/master@{#484039} Committed: https://chromium.googlesource.com/chromium/src/+/ba6175053f21d892273483c16b8e... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/ba6175053f21d892273483c16b8e... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
