Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2946803002: Do not show any search engine promos if disabled by policy. (Closed)

Created:
3 years, 6 months ago by Ted C
Modified:
3 years, 6 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not show any search engine promos if disabled by policy. Changing search engines can be disabled by policy, so we should not attempt to show any search engine related promos if that is the case. BUG=733919 Review-Url: https://codereview.chromium.org/2946803002 Cr-Commit-Position: refs/heads/master@{#480730} Committed: https://chromium.googlesource.com/chromium/src/+/37d0a33a1e1bf8f990938a6aba4afcb44af81de1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -1 line) Patch
M chrome/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/locale/LocaleManagerTest.java View 1 chunk +87 lines, -0 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeJUnit4ClassRunner.java View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Ted C
PTAL
3 years, 6 months ago (2017-06-19 21:55:27 UTC) #2
Yusuf
lgtm
3 years, 6 months ago (2017-06-20 00:08:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2946803002/1
3 years, 6 months ago (2017-06-20 04:18:40 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 04:22:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/37d0a33a1e1bf8f990938a6aba4a...

Powered by Google App Engine
This is Rietveld 408576698