Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2946793002:
[i18n] interstitial_large.html i18n-* to $i18n (Closed)
Description[i18n] interstitial_large.html i18n-* to $i18n
This CL converts the interstitial_large.html page from using
i18n-content and i18n-values (the old way) to $i18n{} (which is the new
faster (less CPU) way).
BUG=677338
Review-Url: https://codereview.chromium.org/2946793002
Cr-Commit-Position: refs/heads/master@{#480894}
Committed: https://chromium.googlesource.com/chromium/src/+/4e7f9af57638c280c79ad8085c2c31fbf625b3f4
Patch Set 1 #
Messages
Total messages: 18 (9 generated)
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
dschuyler@chromium.org changed reviewers: + felt@chromium.org, tommycli@chromium.org
@tommycli, please review for your familiarity with $i18n{} and $i18nRaw{} (and
allow felt@ to RS LGTM it if desired).
@felt for OWNER.
On 2017/06/19 23:53:28, dschuyler wrote:
> @tommycli, please review for your familiarity with $i18n{} and $i18nRaw{} (and
> allow felt@ to RS LGTM it if desired).
>
> @felt for OWNER.
before and after screen shots at http://imgur.com/a/0H9y2
On 2017/06/19 23:53:59, dschuyler wrote:
> On 2017/06/19 23:53:28, dschuyler wrote:
> > @tommycli, please review for your familiarity with $i18n{} and $i18nRaw{}
(and
> > allow felt@ to RS LGTM it if desired).
> >
> > @felt for OWNER.
>
> before and after screen shots at http://imgur.com/a/0H9y2
lgtm usages of $i18n vs $i18nRaw
On 2017/06/20 16:07:50, tommycli wrote:
> On 2017/06/19 23:53:59, dschuyler wrote:
> > On 2017/06/19 23:53:28, dschuyler wrote:
> > > @tommycli, please review for your familiarity with $i18n{} and $i18nRaw{}
> (and
> > > allow felt@ to RS LGTM it if desired).
> > >
> > > @felt for OWNER.
> >
> > before and after screen shots at http://imgur.com/a/0H9y2
>
> lgtm usages of $i18n vs $i18nRaw
OWNERS lgtm
fyi for future reference, we have a set of test pages at chrome://interstitials
that you can use to test different conditions
Description was changed from
==========
[i18n] interstitial_large.html i18n-* to $i18n
This CL converts the interstitial_large.html page from using
i18n-content and i18n-values (the old way) to $i18n{} (which is the new
faster (less CPU) way).
BUG=677338
==========
to
==========
[i18n] interstitial_large.html i18n-* to $i18n
This CL converts the interstitial_large.html page from using
i18n-content and i18n-values (the old way) to $i18n{} (which is the new
faster (less CPU) way).
BUG=677338
==========
+edwardjung fyi. i think you were planning to do this: surprise it's already done! :)
On 2017/06/20 17:33:38, felt wrote: > +edwardjung fyi. i think you were planning to do this: surprise it's already > done! :) Nice!
On 2017/06/20 17:32:57, felt wrote:
> On 2017/06/20 16:07:50, tommycli wrote:
> > On 2017/06/19 23:53:59, dschuyler wrote:
> > > On 2017/06/19 23:53:28, dschuyler wrote:
> > > > @tommycli, please review for your familiarity with $i18n{} and
$i18nRaw{}
> > (and
> > > > allow felt@ to RS LGTM it if desired).
> > > >
> > > > @felt for OWNER.
> > >
> > > before and after screen shots at http://imgur.com/a/0H9y2
> >
> > lgtm usages of $i18n vs $i18nRaw
>
> OWNERS lgtm
>
> fyi for future reference, we have a set of test pages at
chrome://interstitials
> that you can use to test different conditions
Awesome, thanks, that helps. May I suggest adding chrome://interstitials to the
chrome://about URL list (that's where I'd searched for an interstitials test
page and not found it).
The CQ bit was checked by dschuyler@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1497983975792270, "parent_rev":
"f555f5e9b57709a1338cab3df0510722404c9888", "commit_rev":
"4e7f9af57638c280c79ad8085c2c31fbf625b3f4"}
Message was sent while issue was closed.
Description was changed from
==========
[i18n] interstitial_large.html i18n-* to $i18n
This CL converts the interstitial_large.html page from using
i18n-content and i18n-values (the old way) to $i18n{} (which is the new
faster (less CPU) way).
BUG=677338
==========
to
==========
[i18n] interstitial_large.html i18n-* to $i18n
This CL converts the interstitial_large.html page from using
i18n-content and i18n-values (the old way) to $i18n{} (which is the new
faster (less CPU) way).
BUG=677338
Review-Url: https://codereview.chromium.org/2946793002
Cr-Commit-Position: refs/heads/master@{#480894}
Committed:
https://chromium.googlesource.com/chromium/src/+/4e7f9af57638c280c79ad8085c2c...
==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/4e7f9af57638c280c79ad8085c2c... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
