Views a11y: Use AX_ROLE_POP_UP_BUTTON for views::Combobox.

Views a11y: Use AX_ROLE_POP_UP_BUTTON for views::Combobox.

AX_ROLE_COMBO_BOX is for UI elements with an editable textfield, which
views::Combobox does not have. views::Combobox operates most like an
HTML <select> element, which is given kPopUpButtonRole in Blink's
AXNodeObject.cpp (or kListBoxRole if it allows multiple selection).

Use AX_ROLE_POP_UP_BUTTON for views::Combobox on all platforms.

BUG=657900, 663536
Review-Url: https://codereview.chromium.org/2946783003
Cr-Commit-Position: refs/heads/master@{#481163}
Committed: https://chromium.googlesource.com/chromium/src/+/d16b69bc237e5f5d2cc75681aec6d2c130a05f14

[tapted, 2017-06-20 00:41:14]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 00:41:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-06-20 00:50:43]

Description was changed from

==========
Views a11y: Use AX_ROLE_POP_UP_BUTTON for views::Combobox.

AX_ROLE_COMBO_BOX is for UI elements with an editable textfield, which
views::Combobox does not have. views::Combobox operates most like an
HTML <select> element, which is given kPopUpButtonRole in Blink's
AXNodeObject.cpp (or kListBoxRole if it allows multiple selection).

BUG=657900
==========

to

==========
Views a11y: Use AX_ROLE_POP_UP_BUTTON for views::Combobox.

AX_ROLE_COMBO_BOX is for UI elements with an editable textfield, which
views::Combobox does not have. views::Combobox operates most like an
HTML <select> element, which is given kPopUpButtonRole in Blink's
AXNodeObject.cpp (or kListBoxRole if it allows multiple selection).

Use AX_ROLE_POP_UP_BUTTON for views::Combobox on all platforms.

BUG=657900
==========

[tapted, 2017-06-20 00:50:43]

tapted@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[tapted, 2017-06-20 00:51:22]

Hi Dominic, please take a look

[tapted, 2017-06-20 02:11:01]

Description was changed from

==========
Views a11y: Use AX_ROLE_POP_UP_BUTTON for views::Combobox.

AX_ROLE_COMBO_BOX is for UI elements with an editable textfield, which
views::Combobox does not have. views::Combobox operates most like an
HTML <select> element, which is given kPopUpButtonRole in Blink's
AXNodeObject.cpp (or kListBoxRole if it allows multiple selection).

Use AX_ROLE_POP_UP_BUTTON for views::Combobox on all platforms.

BUG=657900
==========

to

==========
Views a11y: Use AX_ROLE_POP_UP_BUTTON for views::Combobox.

AX_ROLE_COMBO_BOX is for UI elements with an editable textfield, which
views::Combobox does not have. views::Combobox operates most like an
HTML <select> element, which is given kPopUpButtonRole in Blink's
AXNodeObject.cpp (or kListBoxRole if it allows multiple selection).

Use AX_ROLE_POP_UP_BUTTON for views::Combobox on all platforms.

BUG=657900, 663536
==========

[commit-bot: I haz the power, 2017-06-20 02:40:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 02:40:29]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2017-06-21 05:57:58]

lgtm

Combobox is one of the most misunderstood controls.

[tapted, 2017-06-21 07:08:17]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2017-06-21 07:08:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 08:01:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 08:01:02]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[tapted, 2017-06-21 09:17:54]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2017-06-21 09:18:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 10:06:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498036674343170,
"parent_rev": "16cafbab6bef1dce2175df58a54028effdacd074", "commit_rev":
"d16b69bc237e5f5d2cc75681aec6d2c130a05f14"}

[commit-bot: I haz the power, 2017-06-21 10:06:59]

Description was changed from

==========
Views a11y: Use AX_ROLE_POP_UP_BUTTON for views::Combobox.

AX_ROLE_COMBO_BOX is for UI elements with an editable textfield, which
views::Combobox does not have. views::Combobox operates most like an
HTML <select> element, which is given kPopUpButtonRole in Blink's
AXNodeObject.cpp (or kListBoxRole if it allows multiple selection).

Use AX_ROLE_POP_UP_BUTTON for views::Combobox on all platforms.

BUG=657900, 663536
==========

to

==========
Views a11y: Use AX_ROLE_POP_UP_BUTTON for views::Combobox.

AX_ROLE_COMBO_BOX is for UI elements with an editable textfield, which
views::Combobox does not have. views::Combobox operates most like an
HTML <select> element, which is given kPopUpButtonRole in Blink's
AXNodeObject.cpp (or kListBoxRole if it allows multiple selection).

Use AX_ROLE_POP_UP_BUTTON for views::Combobox on all platforms.

BUG=657900, 663536

Review-Url: https://codereview.chromium.org/2946783003
Cr-Commit-Position: refs/heads/master@{#481163}
Committed:
https://chromium.googlesource.com/chromium/src/+/d16b69bc237e5f5d2cc75681aec6...
==========

[commit-bot: I haz the power, 2017-06-21 10:07:00]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d16b69bc237e5f5d2cc75681aec6...