|
Use GN buildflags and features to configure account consistency
The configuration was not consistent: Dice was sometimes enabled with
!OS_ANDROID, and sometimes with OS_MAC || OS_LINUX || OS_WIN.
There are also platforms (e.g. ChromeOS) where mirror is not enabled
and Dice is not supported, and thus two different variables are needed.
This CL replaces the platform variables with custom features variables
defined in GN.
Two variables are defined, in GN and in code:
- enable_dice_support
- enable_mirror
Review-Url: https://codereview.chromium.org/2946693002
Cr-Commit-Position: refs/heads/master@{#481520}
Committed: https://chromium.googlesource.com/chromium/src/+/fc443126af3f424433b8d7c9b0194e83b6dba021
Total comments: 3
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+124 lines, -58 lines) |
Patch |
|
M |
chrome/browser/BUILD.gn
|
View
|
1
|
4 chunks |
+9 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/about_flags.cc
|
View
|
1
|
3 chunks |
+8 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/browser/signin/chrome_signin_helper.cc
|
View
|
|
7 chunks |
+8 lines, -7 lines |
0 comments
|
Download
|
|
M |
chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc
|
View
|
1
2
|
3 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/BUILD.gn
|
View
|
1
2
|
4 chunks |
+11 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
|
View
|
1
|
5 chunks |
+12 lines, -7 lines |
0 comments
|
Download
|
|
M |
chrome/common/BUILD.gn
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
chrome/common/url_constants.h
|
View
|
1
|
2 chunks |
+5 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/common/url_constants.cc
|
View
|
1
|
1 chunk |
+4 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/test/BUILD.gn
|
View
|
1
2
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
components/signin/core/browser/BUILD.gn
|
View
|
|
4 chunks |
+14 lines, -9 lines |
0 comments
|
Download
|
|
M |
components/signin/core/browser/signin_header_helper.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
components/signin/core/browser/signin_header_helper.cc
|
View
|
|
3 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
|
M |
components/signin/core/browser/signin_header_helper_unittest.cc
|
View
|
|
5 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
components/signin/core/common/BUILD.gn
|
View
|
|
2 chunks |
+15 lines, -0 lines |
0 comments
|
Download
|
|
M |
components/signin/core/common/profile_management_switches.h
|
View
|
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
components/signin/core/common/profile_management_switches.cc
|
View
|
|
3 chunks |
+9 lines, -4 lines |
0 comments
|
Download
|
|
M |
components/signin/core/common/signin_switches.h
|
View
|
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
components/signin/core/common/signin_switches.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
A |
components/signin/features.gni
|
View
|
1
2
|
1 chunk |
+9 lines, -0 lines |
0 comments
|
Download
|
Depends on Patchset:
Dependent Patchsets:
Total messages: 46 (36 generated)
|