Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2946673003: Aria-details takes an ID reference, not an ID reference list (Closed)

Created:
3 years, 6 months ago by dmazzoni
Modified:
3 years, 6 months ago
Reviewers:
aboxhall
CC:
chromium-reviews, eae+blinkwatch, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, kinuko+watch, rwlbuis, aboxhall, aboxhall+watch_chromium.org, jam, blink-reviews-dom_chromium.org, dglazkov+blink, je_julie, darin-cc_chromium.org, blink-reviews, blink-reviews-api_chromium.org, mlamouri+watch-content_chromium.org, sof, yuzo+watch_chromium.org, dmazzoni, aleventhal+watch_chromium.org, haraken, nektar+watch_chromium.org, nektarios, dtseng+watch_chromium.org, platform-architecture-syd+reviews-web_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Aria-details takes an ID reference, not an ID reference list BUG=644766 Review-Url: https://codereview.chromium.org/2946673003 Cr-Commit-Position: refs/heads/master@{#480877} Committed: https://chromium.googlesource.com/chromium/src/+/14deaa4b7ea427d2a9e013dec4e4a9d6d8d7e58c

Patch Set 1 #

Patch Set 2 : Fix accessibility_unittests #

Patch Set 3 : Rebase #

Patch Set 4 : Fix inspector protocol test #

Patch Set 5 : Fix #

Patch Set 6 : Fix one test expectation #

Patch Set 7 : Fix relations on win #

Patch Set 8 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -40 lines) Patch
M content/browser/accessibility/browser_accessibility_com_win.h View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_com_win.cc View 1 2 3 4 5 6 2 chunks +15 lines, -2 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M content/test/data/accessibility/aria/aria-details-expected-blink.txt View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-aria-1.1.html View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-aria-1.1-expected.txt View 1 2 3 2 chunks +4 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.cpp View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp View 4 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/public/web/WebAXEnums.h View 2 chunks +1 line, -1 line 0 comments Download
M ui/accessibility/ax_enums.idl View 2 chunks +1 line, -1 line 0 comments Download
M ui/accessibility/ax_node_data.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/accessibility/ax_tree_unittest.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 40 (34 generated)
dmazzoni
3 years, 6 months ago (2017-06-19 22:17:29 UTC) #16
aboxhall
LGTM once build/test failures fixed
3 years, 6 months ago (2017-06-20 00:27:23 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2946673003/110001
3 years, 6 months ago (2017-06-20 05:47:26 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/468308)
3 years, 6 months ago (2017-06-20 05:55:20 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2946673003/130001
3 years, 6 months ago (2017-06-20 17:14:03 UTC) #37
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 17:54:07 UTC) #40
Message was sent while issue was closed.
Committed patchset #8 (id:130001) as
https://chromium.googlesource.com/chromium/src/+/14deaa4b7ea427d2a9e013dec4e4...

Powered by Google App Engine
This is Rietveld 408576698