Issue 2946643002: Don't compute 'dart:core' LibraryElement during completion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2946643002: Don't compute 'dart:core' LibraryElement during completion. (Closed)

Created:
3 years, 6 months ago by scheglov

Modified:
3 years, 6 months ago

Reviewers:
danrubel, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Don't compute 'dart:core' LibraryElement during completion. AnalysisResult already has TypeProvider, which can give us Object type. R=brianwilkerson@google.com, danrubel@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f9dc588a2709eac889984018b77743d41c480158

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -33 lines)			Patch
	M	pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart	View		1 chunk	+0 lines, -5 lines	0 comments	Download
	M	pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart	View		6 chunks	+9 lines, -28 lines	0 comments	Download

Total messages: 5 (1 generated)

scheglov

3 years, 6 months ago (2017-06-19 15:18:01 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f9dc588a2709eac889984018b77743d41c480158 (presubmit successful).