Don't compute 'dart:core' LibraryElement during completion.

pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 
 import 'package:analysis_server/src/provisional/completion/completion_core.dart'
     show CompletionContributor, CompletionRequest;
 import 'package:analysis_server/src/provisional/completion/dart/completion_dart.dart';
 import 'package:analysis_server/src/provisional/completion/dart/completion_plugin.dart';
 import 'package:analysis_server/src/services/completion/completion_core.dart';
 import 'package:analysis_server/src/services/completion/completion_performance.dart';
 import 'package:analysis_server/src/services/completion/dart/common_usage_sorter.dart';
 import 'package:analysis_server/src/services/completion/dart/contribution_sorter.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/standard_ast_factory.dart';
-import 'package:analyzer/dart/ast/standard_resolution_map.dart';
 import 'package:analyzer/dart/ast/token.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/type.dart';
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/src/dart/analysis/driver.dart';
 import 'package:analyzer/src/dart/ast/token.dart';
 import 'package:analyzer/src/generated/engine.dart' hide AnalysisResult;
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer/task/model.dart';
 import 'package:analyzer_plugin/protocol/protocol_common.dart';
@@ skipping 70 matching lines @@
 }
 
 /**
  * The information about a requested list of completions within a Dart file.
  */
 class DartCompletionRequestImpl implements DartCompletionRequest {
   @override
   final AnalysisResult result;
 
   @override
-  final LibraryElement coreLib;
+  final ResourceProvider resourceProvider;
+
+  @override
+  final InterfaceType objectType;
 
   @override
   final Source source;
 
   @override
   final int offset;
 
   @override
   Expression dotTarget;
 
   @override
   Source librarySource;
 
   @override
-  final ResourceProvider resourceProvider;
-
-  @override
   CompletionTarget target;
 
-  /**
-   * The [DartType] for Object in dart:core
-   */
-  InterfaceType _objectType;
-
   OpType _opType;
 
   final CompletionRequest _originalRequest;
 
   final CompletionPerformance performance;
 
   DartCompletionRequestImpl._(
       this.result,
       this.resourceProvider,
-      this.coreLib,
+      this.objectType,
       this.librarySource,
       this.source,
       this.offset,
       CompilationUnit unit,
       this._originalRequest,
       this.performance) {
     _updateTargets(unit);
   }
 
   @override
   bool get includeIdentifiers {
     return opType.includeIdentifiers;
   }
 
   @override
   LibraryElement get libraryElement {
     //TODO(danrubel) build the library element rather than all the declarations
     CompilationUnit unit = target.unit;
     if (unit != null) {
       CompilationUnitElement elem = unit.element;
       if (elem != null) {
         return elem.library;
       }
     }
     return null;
   }
 
-  @override
-  InterfaceType get objectType {
-    if (_objectType == null) {
-      _objectType = coreLib.getType('Object').type;
-    }
-    return _objectType;
-  }
-
   OpType get opType {
     if (_opType == null) {
       _opType = new OpType.forCompletion(target, offset);
     }
     return _opType;
   }
 
   @override
   String get sourceContents => result.content;
 
@@ skipping 42 matching lines @@
    * if the completion request has been aborted.
    */
   static Future<DartCompletionRequest> from(CompletionRequest request,
       {ResultDescriptor resultDescriptor}) async {
     request.checkAborted();
     CompletionPerformance performance =
         (request as CompletionRequestImpl).performance;
     const BUILD_REQUEST_TAG = 'build DartCompletionRequest';
     performance.logStartTime(BUILD_REQUEST_TAG);
 
-    Source libSource;
-    CompilationUnit unit;
-    unit = request.result.unit;
-    // TODO(scheglov) support for parts
-    libSource = resolutionMap.elementDeclaredByCompilationUnit(unit).source;
-
-    LibraryElement coreLib =
-        await request.result.driver.getLibraryByUri('dart:core');
+    CompilationUnit unit = request.result.unit;
+    Source libSource = unit.element.library.source;
+    InterfaceType objectType = request.result.typeProvider.objectType;
 
     DartCompletionRequestImpl dartRequest = new DartCompletionRequestImpl._(
         request.result,
         request.resourceProvider,
-        coreLib,
+        objectType,
         libSource,
         request.source,
         request.offset,
         unit,
         request,
         performance);
 
     performance.logElapseTime(BUILD_REQUEST_TAG);
     return dartRequest;
   }
@@ skipping 46 matching lines @@
           if (start <= requestOffset && requestOffset <= end) {
             // Replacement range for import URI
             return new ReplacementRange(start, end - start);
           }
         }
       }
     }
     return new ReplacementRange(requestOffset, 0);
   }
 }