Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2946633002: Check the validity of cache_ weak ptr in DoFinishHeaders (Closed)

Created:
3 years, 6 months ago by shivanisha
Modified:
3 years, 6 months ago
Reviewers:
mmenke
CC:
cbentzel+watch_chromium.org, chromium-reviews, gavinp+disk_chromium.org, jkarlin, net-reviews_chromium.org, Randy Smith (Not in Mondays)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Speculative fix for 734357 There is just one instance of this crash and the report does not tell much about whether its an invalid memory access. I am speculating that may be we need to check if cache_ weak pointer is still valid before invoking a function on it in DoFinishHeaders. Will keep a watch if there are more such crashes reported with more information. BUG=734357 Review-Url: https://codereview.chromium.org/2946633002 Cr-Commit-Position: refs/heads/master@{#480845} Committed: https://chromium.googlesource.com/chromium/src/+/61ec4c2e31c1d1f9dae24a416b0f5b50157f71d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/http/http_cache_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
shivanisha
mmenke@, PTAL, Thanks!
3 years, 6 months ago (2017-06-18 00:34:58 UTC) #6
mmenke
On 2017/06/18 00:34:58, shivanisha wrote: > mmenke@, PTAL, Thanks! LGTM
3 years, 6 months ago (2017-06-19 17:46:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2946633002/1
3 years, 6 months ago (2017-06-20 14:47:55 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 16:21:30 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/61ec4c2e31c1d1f9dae24a416b0f...

Powered by Google App Engine
This is Rietveld 408576698