Run clang-format on .js files in c/b/r/settings

Run clang-format on .js files in c/b/r/settings

R=dschuyler@chromium.org
BUG=567770
NOPRESUBMIT=true  # presubmit thinks there's a tools/roll_clang_format in this CL (but there isn't)
NO_DEPENDENCY_CHECKS=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2946563002
Cr-Commit-Position: refs/heads/master@{#480507}
Committed: https://chromium.googlesource.com/chromium/src/+/141ae1f5ba2d5491fadcedbe51d82b1293bcce95

[Dan Beam, 2017-06-16 22:29:07]

Description was changed from

==========
Run clang-format on .js files in chrome/browser/resources/settings

R=dpapad@chromium.org
BUG=567770
==========

to

==========
Run clang-format on .js files in chrome/browser/resources/settings

R=dpapad@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-06-16 22:29:24]

Description was changed from

==========
Run clang-format on .js files in chrome/browser/resources/settings

R=dpapad@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Run clang-format on .js files in chrome/browser/resources/settings

R=dschuyler@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-06-16 22:29:24]

dbeam@chromium.org changed reviewers:
+ dschuyler@chromium.org
- dpapad@chromium.org

[Dan Beam, 2017-06-16 22:29:38]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 22:29:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-06-16 23:09:07]

https://codereview.chromium.org/2946563002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/about_page/about_page.js (right):

https://codereview.chromium.org/2946563002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/about_page/about_page.js:452: {
Is there an option in the formatter to put '}, {' on the same line (and if so is
that desired)?

https://codereview.chromium.org/2946563002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/about_page/channel_switcher_dialog.js
(right):

https://codereview.chromium.org/2946563002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/about_page/channel_switcher_dialog.js:142:
this.currentChannel_, selectedChannel)) {
This looks incorrect to my eye. I think it's indenting from the function call
rather than the line. My understanding is that this should be four spaces left.

https://codereview.chromium.org/2946563002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/animation/animation.js (right):

https://codereview.chromium.org/2946563002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/animation/animation.js:52: /**
This looks incorrect (or the lines that follow are incorrect).

https://codereview.chromium.org/2946563002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/device_page/layout_behavior.js (right):

https://codereview.chromium.org/2946563002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/device_page/layout_behavior.js:212:
(Object.assign({}, bounds)));
This is a parameter continuation so it should be indented, but I guess it's
seeing it as a comment. I'm not sure if that can be fixed -- maybe if there's
some way to give a regex saying this is not a normal comment.

https://codereview.chromium.org/2946563002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.js
(right):

https://codereview.chromium.org/2946563002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.js:48:
'12',
Will removing the last comma bring this back to one line (that looks better on
this list).

[commit-bot: I haz the power, 2017-06-16 23:51:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 23:51:45]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2017-06-17 00:11:06]

https://codereview.chromium.org/2946563002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/about_page/about_page.js (right):

https://codereview.chromium.org/2946563002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/about_page/about_page.js:452: {
On 2017/06/16 23:09:06, dschuyler wrote:
> Is there an option in the formatter to put '}, {' on the same line (and if so
is
> that desired)?

¯\_(ツ)_/¯

https://codereview.chromium.org/2946563002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/about_page/channel_switcher_dialog.js
(right):

https://codereview.chromium.org/2946563002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/about_page/channel_switcher_dialog.js:142:
this.currentChannel_, selectedChannel)) {
On 2017/06/16 23:09:07, dschuyler wrote:
> This looks incorrect to my eye. I think it's indenting from the function call
> rather than the line. My understanding is that this should be four spaces
left.

no, this is right

https://codereview.chromium.org/2946563002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/animation/animation.js (right):

https://codereview.chromium.org/2946563002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/animation/animation.js:52: /**
On 2017/06/16 23:09:07, dschuyler wrote:
> This looks incorrect (or the lines that follow are incorrect).

this is code is cray to begin with.  turned clang-format off for this part

https://codereview.chromium.org/2946563002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/device_page/layout_behavior.js (right):

https://codereview.chromium.org/2946563002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/device_page/layout_behavior.js:212:
(Object.assign({}, bounds)));
On 2017/06/16 23:09:07, dschuyler wrote:
> This is a parameter continuation so it should be indented, but I guess it's
> seeing it as a comment. I'm not sure if that can be fixed -- maybe if there's
> some way to give a regex saying this is not a normal comment.

eh, i think this is fine

https://codereview.chromium.org/2946563002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.js
(right):

https://codereview.chromium.org/2946563002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.js:48:
'12',
On 2017/06/16 23:09:07, dschuyler wrote:
> Will removing the last comma bring this back to one line (that looks better on
> this list).

Done.

[Dan Beam, 2017-06-17 00:24:02]

Description was changed from

==========
Run clang-format on .js files in chrome/browser/resources/settings

R=dschuyler@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Run clang-format on .js files in c/b/r/settings

R=dschuyler@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-06-17 00:24:20]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-17 00:24:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-06-17 00:30:57]

lgtm

[Dan Beam, 2017-06-17 00:31:56]

The CQ bit was unchecked by dbeam@chromium.org

[Dan Beam, 2017-06-17 00:32:01]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-06-17 00:32:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-17 00:32:05]

This CL has an open dependency (Issue 2941973002 Patch 1). Please resolve the
dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[Dan Beam, 2017-06-17 00:33:42]

Description was changed from

==========
Run clang-format on .js files in c/b/r/settings

R=dschuyler@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Run clang-format on .js files in c/b/r/settings

R=dschuyler@chromium.org
BUG=567770
NO_DEPENDENCY_CHECKS=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-06-17 00:33:49]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-06-17 00:34:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-17 00:46:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-17 00:46:28]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Dan Beam, 2017-06-19 07:14:33]

Description was changed from

==========
Run clang-format on .js files in c/b/r/settings

R=dschuyler@chromium.org
BUG=567770
NO_DEPENDENCY_CHECKS=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Run clang-format on .js files in c/b/r/settings

R=dschuyler@chromium.org
BUG=567770
NOPRESUBMIT=true  # presubmit thinks there's a tools/roll_clang_format in this
CL (but there isn't)
NO_DEPENDENCY_CHECKS=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-06-19 07:14:41]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-06-19 07:14:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 08:09:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 08:09:46]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Dan Beam, 2017-06-19 17:04:36]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-06-19 17:04:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 18:28:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497891876902610,
"parent_rev": "1d05904bcc684ee1267bcef56496a9c3ebce2b61", "commit_rev":
"79c9315cde0345a35a1cf754f5fba76c142b6bd9"}

[commit-bot: I haz the power, 2017-06-19 18:28:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497891876902610,
"parent_rev": "5e072b4381c3291ebd3b265143326bfd667c77ae", "commit_rev":
"84cfde1c79c53cf7237d6f276207559fb67b62d8"}

[commit-bot: I haz the power, 2017-06-19 18:29:08]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497891876902610,
"parent_rev": "98ad90faa4f3991c6cf727da75f94da73db32be0", "commit_rev":
"141ae1f5ba2d5491fadcedbe51d82b1293bcce95"}

[commit-bot: I haz the power, 2017-06-19 18:29:22]

Description was changed from

==========
Run clang-format on .js files in c/b/r/settings

R=dschuyler@chromium.org
BUG=567770
NOPRESUBMIT=true  # presubmit thinks there's a tools/roll_clang_format in this
CL (but there isn't)
NO_DEPENDENCY_CHECKS=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Run clang-format on .js files in c/b/r/settings

R=dschuyler@chromium.org
BUG=567770
NOPRESUBMIT=true  # presubmit thinks there's a tools/roll_clang_format in this
CL (but there isn't)
NO_DEPENDENCY_CHECKS=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2946563002
Cr-Commit-Position: refs/heads/master@{#480507}
Committed:
https://chromium.googlesource.com/chromium/src/+/141ae1f5ba2d5491fadcedbe51d8...
==========

[commit-bot: I haz the power, 2017-06-19 18:29:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/141ae1f5ba2d5491fadcedbe51d8...