Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2946543002: Cros Tablet: Add UMA stats for the user close actions in tablet mode. (Closed)

Created:
3 years, 6 months ago by xdai1
Modified:
3 years, 6 months ago
CC:
chromium-reviews, kalyank, sadrul, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Cros Tablet: Add UMA stats for the user close actions in tablet mode. There are three ways to close a browser/app window in tablet mode: 1) from the close button in the title bar area on the top right corner of the window 2) from the close button in overview mode 3) from the shelf icon context menu The goal is to evaluate the three ways to close a window in tablet mode to see if we can remove the title bar for a tablet window. BUG=732983 Review-Url: https://codereview.chromium.org/2946543002 Cr-Commit-Position: refs/heads/master@{#480489} Committed: https://chromium.googlesource.com/chromium/src/+/80f52fd8f2b2ed19058e8f819962272a68387bdd

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address asvitkine@'s comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
M ash/frame/caption_buttons/frame_caption_button_container_view.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ash/metrics/user_metrics_action.h View 1 chunk +6 lines, -0 lines 0 comments Download
M ash/metrics/user_metrics_recorder.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M ash/wm/overview/window_selector_item.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
xdai1
oshima@, asvitkine@, could you help review this CL please? Thanks! asvitkine@: tools/metrics/actions/actions.xml oshima@: all other ...
3 years, 6 months ago (2017-06-16 22:10:17 UTC) #4
oshima
lgtm
3 years, 6 months ago (2017-06-16 23:33:00 UTC) #7
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/2946543002/diff/1/tools/metrics/actions/actions.xml File tools/metrics/actions/actions.xml (right): https://codereview.chromium.org/2946543002/diff/1/tools/metrics/actions/actions.xml#newcode16596 tools/metrics/actions/actions.xml:16596: tablet mode. If this is CrOS-specific, please mention ...
3 years, 6 months ago (2017-06-19 14:48:56 UTC) #8
xdai1
Thanks for the review! https://codereview.chromium.org/2946543002/diff/1/tools/metrics/actions/actions.xml File tools/metrics/actions/actions.xml (right): https://codereview.chromium.org/2946543002/diff/1/tools/metrics/actions/actions.xml#newcode16596 tools/metrics/actions/actions.xml:16596: tablet mode. On 2017/06/19 14:48:56, ...
3 years, 6 months ago (2017-06-19 17:05:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2946543002/20001
3 years, 6 months ago (2017-06-19 17:05:55 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-19 17:44:00 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/80f52fd8f2b2ed19058e8f819962...

Powered by Google App Engine
This is Rietveld 408576698