Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2946513002:
Manage focus in overlays. (Closed)
|
Created:
3 years, 6 months ago by benjhayden Modified:
3 years, 6 months ago Reviewers:
eakuefner CC:
catapult-reviews_chromium.org, tracing-review_chromium.org Target Ref:
refs/heads/master Project:
catapult Visibility:
Public. |
DescriptionManage focus in overlays.
Currently, whenever any elements other than the overlay <div> itself receives
focus, the overlay immediately steals it back.
https://github.com/catapult-project/catapult/commit/22cfc4803f75e4bf370c50dedc3a143934df227d
This is ok for radio buttons and checkboxes, but catastrophic for select boxes,
which can only be interacted with while focused.
This CL makes overlay only steal focus back when the user tries to focus on
something outside of the overlay. This allows select boxes inside of the overlay
to maintain focus so that users can interact with them.
I can't figure out why this ever worked. Maybe Chrome behavior changed?
BUG=chromium:733991
Review-Url: https://codereview.chromium.org/2946513002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/57e600c76c9f2f6ab3a5b82d3cc21ca738a62a7e
Patch Set 1 #
Messages
Total messages: 19 (12 generated)
Description was changed from ========== Manage focus in overlays. Currently, whenever any elements besides the overlay <div> receives focus, the overlay immediately steals it back. This is ok for radio buttons and checkboxes, but catastrophic for select boxes. This CL makes overlay only steal focus back when the user tries to focus on something outside of the overlay. This allows select boxes inside of the overlay to receive focus. BUG=#733991 ========== to ========== Manage focus in overlays. Currently, whenever any elements besides the overlay <div> receives focus, the overlay immediately steals it back. This is ok for radio buttons and checkboxes, but catastrophic for select boxes, which can only be interacted with while focused. This CL makes overlay only steal focus back when the user tries to focus on something outside of the overlay. This allows select boxes inside of the overlay to maintain focus so that users can interact with them. I can't figure out why this ever worked. Maybe Chrome behavior changed? BUG=#733991 ==========
Description was changed from ========== Manage focus in overlays. Currently, whenever any elements besides the overlay <div> receives focus, the overlay immediately steals it back. This is ok for radio buttons and checkboxes, but catastrophic for select boxes, which can only be interacted with while focused. This CL makes overlay only steal focus back when the user tries to focus on something outside of the overlay. This allows select boxes inside of the overlay to maintain focus so that users can interact with them. I can't figure out why this ever worked. Maybe Chrome behavior changed? BUG=#733991 ========== to ========== Manage focus in overlays. Currently, whenever any elements besides the overlay <div> receives focus, the overlay immediately steals it back. https://github.com/catapult-project/catapult/commit/22cfc4803f75e4bf370c50ded... This is ok for radio buttons and checkboxes, but catastrophic for select boxes, which can only be interacted with while focused. This CL makes overlay only steal focus back when the user tries to focus on something outside of the overlay. This allows select boxes inside of the overlay to maintain focus so that users can interact with them. I can't figure out why this ever worked. Maybe Chrome behavior changed? BUG=#733991 ==========
Description was changed from ========== Manage focus in overlays. Currently, whenever any elements besides the overlay <div> receives focus, the overlay immediately steals it back. https://github.com/catapult-project/catapult/commit/22cfc4803f75e4bf370c50ded... This is ok for radio buttons and checkboxes, but catastrophic for select boxes, which can only be interacted with while focused. This CL makes overlay only steal focus back when the user tries to focus on something outside of the overlay. This allows select boxes inside of the overlay to maintain focus so that users can interact with them. I can't figure out why this ever worked. Maybe Chrome behavior changed? BUG=#733991 ========== to ========== Manage focus in overlays. Currently, whenever any elements other than the overlay <div> itself receives focus, the overlay immediately steals it back. https://github.com/catapult-project/catapult/commit/22cfc4803f75e4bf370c50ded... This is ok for radio buttons and checkboxes, but catastrophic for select boxes, which can only be interacted with while focused. This CL makes overlay only steal focus back when the user tries to focus on something outside of the overlay. This allows select boxes inside of the overlay to maintain focus so that users can interact with them. I can't figure out why this ever worked. Maybe Chrome behavior changed? BUG=#733991 ==========
benjhayden@chromium.org changed reviewers: + eakuefner@chromium.org
PTAL
lgtm -- would it be worth cherry-picking the corresponding catapult roll to stable once this lands? also, have we found someone to follow up with regarding whether chrome behavior changed?
On 2017/06/16 at 21:12:45, eakuefner wrote: > lgtm -- would it be worth cherry-picking the corresponding catapult roll to stable once this lands? also, have we found someone to follow up with regarding whether chrome behavior changed? I will forward those questions to the bug since I don't have an answer for them now. Thanks!
The CQ bit was checked by benjhayden@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)
Description was changed from ========== Manage focus in overlays. Currently, whenever any elements other than the overlay <div> itself receives focus, the overlay immediately steals it back. https://github.com/catapult-project/catapult/commit/22cfc4803f75e4bf370c50ded... This is ok for radio buttons and checkboxes, but catastrophic for select boxes, which can only be interacted with while focused. This CL makes overlay only steal focus back when the user tries to focus on something outside of the overlay. This allows select boxes inside of the overlay to maintain focus so that users can interact with them. I can't figure out why this ever worked. Maybe Chrome behavior changed? BUG=#733991 ========== to ========== Manage focus in overlays. Currently, whenever any elements other than the overlay <div> itself receives focus, the overlay immediately steals it back. https://github.com/catapult-project/catapult/commit/22cfc4803f75e4bf370c50ded... This is ok for radio buttons and checkboxes, but catastrophic for select boxes, which can only be interacted with while focused. This CL makes overlay only steal focus back when the user tries to focus on something outside of the overlay. This allows select boxes inside of the overlay to maintain focus so that users can interact with them. I can't figure out why this ever worked. Maybe Chrome behavior changed? BUG=chrome:#733991 ==========
Description was changed from ========== Manage focus in overlays. Currently, whenever any elements other than the overlay <div> itself receives focus, the overlay immediately steals it back. https://github.com/catapult-project/catapult/commit/22cfc4803f75e4bf370c50ded... This is ok for radio buttons and checkboxes, but catastrophic for select boxes, which can only be interacted with while focused. This CL makes overlay only steal focus back when the user tries to focus on something outside of the overlay. This allows select boxes inside of the overlay to maintain focus so that users can interact with them. I can't figure out why this ever worked. Maybe Chrome behavior changed? BUG=chrome:#733991 ========== to ========== Manage focus in overlays. Currently, whenever any elements other than the overlay <div> itself receives focus, the overlay immediately steals it back. https://github.com/catapult-project/catapult/commit/22cfc4803f75e4bf370c50ded... This is ok for radio buttons and checkboxes, but catastrophic for select boxes, which can only be interacted with while focused. This CL makes overlay only steal focus back when the user tries to focus on something outside of the overlay. This allows select boxes inside of the overlay to maintain focus so that users can interact with them. I can't figure out why this ever worked. Maybe Chrome behavior changed? BUG=chromium:#733991 ==========
Description was changed from ========== Manage focus in overlays. Currently, whenever any elements other than the overlay <div> itself receives focus, the overlay immediately steals it back. https://github.com/catapult-project/catapult/commit/22cfc4803f75e4bf370c50ded... This is ok for radio buttons and checkboxes, but catastrophic for select boxes, which can only be interacted with while focused. This CL makes overlay only steal focus back when the user tries to focus on something outside of the overlay. This allows select boxes inside of the overlay to maintain focus so that users can interact with them. I can't figure out why this ever worked. Maybe Chrome behavior changed? BUG=chromium:#733991 ========== to ========== Manage focus in overlays. Currently, whenever any elements other than the overlay <div> itself receives focus, the overlay immediately steals it back. https://github.com/catapult-project/catapult/commit/22cfc4803f75e4bf370c50ded... This is ok for radio buttons and checkboxes, but catastrophic for select boxes, which can only be interacted with while focused. This CL makes overlay only steal focus back when the user tries to focus on something outside of the overlay. This allows select boxes inside of the overlay to maintain focus so that users can interact with them. I can't figure out why this ever worked. Maybe Chrome behavior changed? BUG=chromium:733991 ==========
The CQ bit was checked by benjhayden@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1497648030259480, "parent_rev":
"c49e46f52bd65975f05f0de4d5bec96c54a40a07", "commit_rev":
"57e600c76c9f2f6ab3a5b82d3cc21ca738a62a7e"}
Message was sent while issue was closed.
Description was changed from ========== Manage focus in overlays. Currently, whenever any elements other than the overlay <div> itself receives focus, the overlay immediately steals it back. https://github.com/catapult-project/catapult/commit/22cfc4803f75e4bf370c50ded... This is ok for radio buttons and checkboxes, but catastrophic for select boxes, which can only be interacted with while focused. This CL makes overlay only steal focus back when the user tries to focus on something outside of the overlay. This allows select boxes inside of the overlay to maintain focus so that users can interact with them. I can't figure out why this ever worked. Maybe Chrome behavior changed? BUG=chromium:733991 ========== to ========== Manage focus in overlays. Currently, whenever any elements other than the overlay <div> itself receives focus, the overlay immediately steals it back. https://github.com/catapult-project/catapult/commit/22cfc4803f75e4bf370c50ded... This is ok for radio buttons and checkboxes, but catastrophic for select boxes, which can only be interacted with while focused. This CL makes overlay only steal focus back when the user tries to focus on something outside of the overlay. This allows select boxes inside of the overlay to maintain focus so that users can interact with them. I can't figure out why this ever worked. Maybe Chrome behavior changed? BUG=chromium:733991 Review-Url: https://codereview.chromium.org/2946513002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
