Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Issue 2946493002: [Chrome Home] Avoid restart if experiment enabled after FRE. (Closed)

Created:
3 years, 6 months ago by Ted C
Modified:
3 years, 6 months ago
Reviewers:
mdjones
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chrome Home] Avoid restart if experiment enabled after FRE. When determining if Chrome Home is enabled, check if the native libraries have been initialized by the time the feature boolean is first read (i.e. because FRE already happened and init'd the browser process). If the libraries have been initialized, also check the finch flag value to determine if we should show Chrome home. TEST=1.) Clear data, kill Chrome 2.) build/android/adb_chrome_public_command_line "--enable-features=ChromeHome" 3.) Start Chrome and proceed through FRE, see you are in Chrome Home w/o restarting. BUG=731295 Review-Url: https://codereview.chromium.org/2946493002 Cr-Commit-Position: refs/heads/master@{#480191} Committed: https://chromium.googlesource.com/chromium/src/+/fd3ce8c51b5b17427615582a9566bc0afa3d1907

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Ted C
PTAL
3 years, 6 months ago (2017-06-16 19:59:44 UTC) #2
mdjones
lgtm
3 years, 6 months ago (2017-06-16 21:07:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2946493002/1
3 years, 6 months ago (2017-06-16 21:10:06 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 22:07:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fd3ce8c51b5b17427615582a9566...

Powered by Google App Engine
This is Rietveld 408576698